22.1.0 #420
Merged
22.1.0 #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jiexi
reviewed
Apr 28, 2025
CHANGELOG.md
Outdated
| ### Changed | ||
|
|
||
| - Refactor CAIP294 announcement logic ([#419](https://github.com/MetaMask/providers/pull/419)) | ||
| - Adds a new `shouldAnnounceCaip294` flag to `initializeProvider` options (defaulted to true), so instead of the `providerInfo.rdns` value determining whether or not to announce the caip-294 target, the caller of `initializeProvider` can directly control this. |
Contributor
There was a problem hiding this comment.
thoughts on replacing the Refactor CAIP294 announcement logic line with the sub point?
jiexi
approved these changes
Apr 28, 2025
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 29, 2025
…ultichain API on all build types (#32351) Previously the Multichain API was only available on Flask and Beta builds. Starting in 12.18.0 we are releasing the Multichain API to all build types including `stable` [](https://codespaces.new/MetaMask/metamask-extension/pull/32351?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#4779 ## **Manual testing steps** 1. Build this branch in a normal stable build (`yarn start`) 2. Go to https://metamask.github.io/test-dapp-multichain/latest/ 3. Enter your extensionId (watch video below to see where) -> Detection on `stable` blocked by MetaMask/providers#420 4. See that you're able to connect and interact with the multichain api ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/282cfd24-428f-4eff-ab27-1a9424c27ad0 ### **After** https://github.com/user-attachments/assets/7af12e3c-05a8-4277-a439-5c54fefdd13d ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: jiexi <jiexiluan@gmail.com>
DDDDDanica
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 30, 2025
…ultichain API on all build types (#32351) Previously the Multichain API was only available on Flask and Beta builds. Starting in 12.18.0 we are releasing the Multichain API to all build types including `stable` [](https://codespaces.new/MetaMask/metamask-extension/pull/32351?quickstart=1) Fixes: MetaMask/MetaMask-planning#4779 1. Build this branch in a normal stable build (`yarn start`) 2. Go to https://metamask.github.io/test-dapp-multichain/latest/ 3. Enter your extensionId (watch video below to see where) -> Detection on `stable` blocked by MetaMask/providers#420 4. See that you're able to connect and interact with the multichain api <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/282cfd24-428f-4eff-ab27-1a9424c27ad0 https://github.com/user-attachments/assets/7af12e3c-05a8-4277-a439-5c54fefdd13d - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: jiexi <jiexiluan@gmail.com>
14 tasks
DDDDDanica
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 30, 2025
…ultichain API on all build types (#32351) Cherry-pick (#32409) Previously the Multichain API was only available on Flask and Beta builds. Starting in 12.18.0 we are releasing the Multichain API to all build types including `stable` [](https://codespaces.new/MetaMask/metamask-extension/pull/32351?quickstart=1) Cherry-pick: https://github.com/MetaMask/metamask-extension/pull/32351/files Fixes: MetaMask/MetaMask-planning#4779 1. Build this branch in a normal stable build (`yarn start`) 2. Go to https://metamask.github.io/test-dapp-multichain/latest/ 3. Enter your extensionId (watch video below to see where) -> Detection on `stable` blocked by MetaMask/providers#420 4. See that you're able to connect and interact with the multichain api <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/282cfd24-428f-4eff-ab27-1a9424c27ad0 https://github.com/user-attachments/assets/7af12e3c-05a8-4277-a439-5c54fefdd13d - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/32409?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Alex Donesky <adonesky@gmail.com> Co-authored-by: jiexi <jiexiluan@gmail.com>
DDDDDanica
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
May 1, 2025
…ultichain API on all build types (#32351) Cherry-pick (#32409) Previously the Multichain API was only available on Flask and Beta builds. Starting in 12.18.0 we are releasing the Multichain API to all build types including `stable` [](https://codespaces.new/MetaMask/metamask-extension/pull/32351?quickstart=1) Cherry-pick: https://github.com/MetaMask/metamask-extension/pull/32351/files Fixes: MetaMask/MetaMask-planning#4779 1. Build this branch in a normal stable build (`yarn start`) 2. Go to https://metamask.github.io/test-dapp-multichain/latest/ 3. Enter your extensionId (watch video below to see where) -> Detection on `stable` blocked by MetaMask/providers#420 4. See that you're able to connect and interact with the multichain api <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/282cfd24-428f-4eff-ab27-1a9424c27ad0 https://github.com/user-attachments/assets/7af12e3c-05a8-4277-a439-5c54fefdd13d - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/32409?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Alex Donesky <adonesky@gmail.com> Co-authored-by: jiexi <jiexiluan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://codespaces.new/MetaMask/metamask-extension/pull/32351?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/32409?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[22.1.0]
Changed
shouldAnnounceCaip294flag toinitializeProvideroptions (defaulted to true), so instead of theproviderInfo.rdnsvalue determining whether or not to announce the caip-294 target, the caller ofinitializeProvidercan directly control this.