Refactor caip-294 announcement logic #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
commented
Apr 28, 2025
jest.config.js
Outdated
Comment on lines
48
to
51
| branches: 70.0, | ||
| functions: 72.07, | ||
| lines: 70.82, | ||
| statements: 70.95, |
Contributor
Author
There was a problem hiding this comment.
I wrestled with the tests a bit and mocking became quite frustrating. I think this is fine for now 😅
adonesky1
force-pushed
the
ad/modify-caip294-announcement-logic
branch
from
239d3ac to
5e6a780
Compare
jiexi
approved these changes
Apr 28, 2025
This was referenced Apr 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how we determine whether to announce CAIP-294 wallet data:
shouldAnnounceCaip294flag toinitializeProvideroptionsgetBuildTypefunction which is no longer neededInstead of relying on the wallet's rdns to determine whether CAIP-294 announcements should be made (previously only "flask" builds would announce), this change gives direct control to the client. This is a more flexible approach that decouples announcement logic from wallet identification details, allowing each client to make this determination based on their own requirements.