feat: Enhance CAIP-294 wallet announcement for mobile flask builds #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests to ensure wallet is not announced for mobile builds unless the build type is 'flask'. - Updated `getBuildType` function to recognize mobile build types and return appropriate values. - Enhanced `announceCaip294WalletData` to handle mobile flask builds with CAIP-348 targets.
abretonc7s
changed the title
ffmcgee725
approved these changes
Apr 28, 2025
jiexi
reviewed
Apr 28, 2025
| }); | ||
|
|
||
| it('should announce wallet with caip-348 target for mobile flask', async () => { | ||
| const extensionId = 'test-extension-id'; |
Contributor
There was a problem hiding this comment.
nit. mobile won't have an extension id, so a caip-348 target won't be announced.
Contributor
|
Superceded by: #419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purpose and Impact
This PR improves CAIP-294 wallet announcement logic to support mobile builds, ensuring announcements only occur for 'flask' mobile builds.
Key Implementation Details
getBuildTypeinsrc/extension-provider/createExternalExtensionProvider.tsto map mobile rdns:io.metamask.mobile→stableio.metamask.mobile.beta→betaio.metamask.mobile.flask→flaskannounceCaip294WalletDatato skip announcements for non-flask mobile builds and include CAIP-348 targets for flask mobile builds.src/extension-provider/createExternalExtensionProvider.test.tsandsrc/initializeInpageProvider.test.tsto verify build type detection and announcement logic.Breaking Changes
None. Changes are backward compatible.