Skip to content

Conversation

@Tyschenko
Copy link
Contributor

Description

I added functionality to detect phishing websites inside iFrames.
Main change in the app: #16706

Changes in the library:
Android change: MetaMask/react-native-webview-mm#60
iOS change: MetaMask/react-native-webview-mm#61

Related issues

Fixes:
https://github.com/MetaMask/mobile-planning/issues/2227

Manual testing steps

  1. Go to https://lol-au4.pages.dev/cb in app browser
  2. Make sure phishing alert is displayed

Screenshots/Recordings

Android and iOS videos:
https://github.com/user-attachments/assets/dba5ff6e-5c7b-41d6-9a8c-426dfb7dede6
https://github.com/user-attachments/assets/dd90b6d5-28c6-47de-9ee6-daa5f048ea44

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…etection of phishing websites inside iframes and reporting them to the app to display an alert
@Tyschenko Tyschenko requested a review from smilingkylan July 21, 2025 19:01
@Tyschenko Tyschenko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team Run Smoke E2E labels Jul 21, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 22461f9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5ad056c3-817e-49d9-97c8-93ee5afdab35

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security
Copy link

socket-security bot commented Jul 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​react-native-webview@​14.2.2 ⏵ 14.3.086 -21009596 +1100

View full report

@socket-security
Copy link

socket-security bot commented Jul 21, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.73%. Comparing base (5184987) to head (22461f9).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17426      +/-   ##
==========================================
+ Coverage   73.57%   73.73%   +0.16%     
==========================================
  Files        2845     2846       +1     
  Lines       63338    63643     +305     
  Branches    10328    10396      +68     
==========================================
+ Hits        46598    46925     +327     
+ Misses      13741    13691      -50     
- Partials     2999     3027      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@Tyschenko Tyschenko closed this Jul 31, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants