feat: Inject Javascript to detect all iFrames inside the current page and report them to the React app #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and report them to the React app
| const iframe = iframes[i]; | ||
| const src = iframe.src; | ||
|
|
||
| if (src && src.trim() !== '' && (src.startsWith('http://') || src.startsWith('https://') || src.startsWith('//'))) { |
There was a problem hiding this comment.
What's the reasoning for including src.startsWith('//') ?
Author
There was a problem hiding this comment.
I think if you specify iFrame with //, it will use current website's protocol (http or https)
smilingkylan
approved these changes
Jun 25, 2025
This was referenced Jun 26, 2025
Merged
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Jul 21, 2025
…e urls and send them to React Native app (#16706) ## **Description** Issue: https://github.com/MetaMask/mobile-planning/issues/2227 We currently have an anti-fishing warning which is displayed when user opens a malicious website. But there is a way to bypass this warning if you load a malicious website via iFrame. Example of the malicious website: https://coin-qr.to/ Example of the website with a malicious iFrame: https://lol-au4.pages.dev/cb (opens coin-qr.to inside in the iFrame) We can inject a JS script in the mobile browser that will check webpage's iFrames and report their URLs to the browser in MetaMask mobile app. ## **Related issues** Android change: MetaMask/react-native-webview-mm#60 iOS change: MetaMask/react-native-webview-mm#61 ## **Manual testing steps** 1. Go to https://lol-au4.pages.dev/cb 2. Make sure warning is displayed 3. Go to coin-qr.to 4. Make sure warning is displayed 5. Go to uniswap.org 6. Make sure NO warning is displayed ## **Screenshots/Recordings** Android and iOS videos: https://github.com/user-attachments/assets/dba5ff6e-5c7b-41d6-9a8c-426dfb7dede6 https://github.com/user-attachments/assets/dd90b6d5-28c6-47de-9ee6-daa5f048ea44 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have an anti-fishing warning which is displayed when user opens a malicious website.
But there is a way to bypass this warning if you load a malicious website via iFrame.
We can inject a JS script in the mobile browser that will check webpage's iFrames and report their URLs to the browser in MetaMask mobile app.