chore(runway): cherry-pick chore: cp-7.51.0 faster address checksum (#16926)

[runway-github]

• chore: cp-7.51.0 faster address checksum (chore: cp-7.51.0 faster address checksum #16926) (chore: cp-7.51.0 faster address checksum (#16926) #17174)

Description

This PR is
originally from @Nodonisko from Margelo

This PR uses new faster memoized functions for working with address
checksum.

There is already significant boost in AccountList performance and it
should be even better when MetaMask/core#6054 is
released and also when we fix Blockies Avatars.

Related issues

Fixes: #15560

Manual testing steps

1. Open Account List
2. It should feel faster than before

Screenshots/Recordings

Before

You can set that before then was lot of interrupted work before Account
List modal is even displayed. It takes around ~7s from click to modal to
be actually visible.

After

Here it takes only around ~3s to mount. (still slow but much better than
before)

Pre-merge author checklist

• I’ve followed MetaMask Contributor
  Docs and [MetaMask Mobile
  Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).

• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

Co-authored-by: Daniel Suchý suchydan@gmail.com 55bc8a6

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f2c2b73
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d9a743f6-49a7-46d7-8836-6dae2345a3a2

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[Cal-L]

LGTM

[cursor]

Bug: Error Handling Flaw in `toChecksumAddress`

The new toChecksumAddress function has flawed and fragile error handling. It attempts backward compatibility by returning certain invalid hex strings (e.g., "0x1", "0x2") as Hex types if isStrictHexString passes, even when getChecksumAddress deems them invalid. This logic relies on catching getChecksumAddress errors with the exact message 'Invalid hex address.', making it fragile. A future change in @metamask/utils error messages would break this specific error handling, causing the original error to be re-thrown instead of handled as intended.

app/util/address/index.ts#L484-L501

metamask-mobile/app/util/address/index.ts

Lines 484 to 501 in 753c871

	export function toChecksumAddress(address: string) {
	try {
	return getChecksumAddress(address as Hex);
	} catch (error) {
	// This is necessary for backward compatibility with the old behavior of
	// `ethereumjs-util` which would return the original string if the address
	// was invalid. This should happen only in tests which uses invalid addresses
	// like 0x1, 0x2 etc.
	if (error instanceof Error && error.message === 'Invalid hex address.') {
	if (isStrictHexString(address)) {
	return address as Hex;
	}
	throw new Error('Invalid hex address.');
	}
	throw error;
	}
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

[metamaskbot]

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.