refactor(extension,kernel): Move kernel message handling to Kernel #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
grypez
changed the base branch from
main
to
grypez/move-kernel-to-dedicated-worker-with-message-channel
grypez
force-pushed
the
grypez/move-kernel-to-dedicated-worker-with-message-channel
branch
3 times, most recently
from
cb6e33f to
70e43cc
Compare
grypez
force-pushed
the
grypez/offscreen-doc-with-message-channel
branch
from
b3b1fa4 to
edda13e
Compare
grypez
changed the title
Contributor
Author
|
#98 |
rekmarks
reviewed
Oct 10, 2024
rekmarks
reviewed
Oct 10, 2024
packages/kernel/src/Kernel.ts
Outdated
Comment on lines
29
to
30
| // Hopefully removed when we get to n+1 vats. | ||
| readonly #defaultVat: PromiseKit<Vat>; |
Member
There was a problem hiding this comment.
grypez
force-pushed
the
grypez/move-kernel-to-dedicated-worker-with-message-channel
branch
from
217cb81 to
cc274b8
Compare
Base automatically changed from
grypez/move-kernel-to-dedicated-worker-with-message-channel
to
main
October 10, 2024 22:38
grypez
force-pushed
the
grypez/offscreen-doc-with-message-channel
branch
5 times, most recently
from
b2ff125 to
16f1b1f
Compare
grypez
force-pushed
the
grypez/offscreen-doc-with-message-channel
branch
from
16f1b1f to
af6ee52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@ocap/extension@ocap/kernelKernelStoreinterface to be supplied to theKernelconstructor.@ocap/extension's kernel worker intoKernel.