feat(shims): Bundle endoify dependencies #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI build job requires that yarn build succeeds with node 20. The CI test job (essentially) requires that yarn test succeeds with node 18 and 20. The test job does not have access to the build artifacts from the build job, which allows the build and test jobs to run in parallel. In order to allow the shims package to test its built shims, we prefix the shims test command with `build && `, which, as a command called during the CI test job, runs with both node 18 and 20. Therefore, although our CI suggests the intended workflow for the ocap monorepo is "build with 20, run with 18 or 20", the tests tighten the constraint in the shims package specifically to "build and run with 18 or 20". As @SMotaal noted, this change in commit is sufficient to meet the tighter constraint.
rekmarks
reviewed
Aug 24, 2024
Comment on lines
+16
to
+17
| // eslint-disable-next-line no-empty-function | ||
| teardown(): void {}, |
Member
There was a problem hiding this comment.
For future reference, this is equivalent and unoffensive to the linter:
Suggested change
| // eslint-disable-next-line no-empty-function | |
| teardown(): void {}, | |
| teardown(): void { | |
| return undefined; | |
| }, |
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
Refs: #21, #31
Copies untransformed the dependencies of
src/endoify.mjsinto the header ofdist/endoify.mjs.