generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(shims): Bundle endoify dependencies #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0262fc0
fix(shims): Add glob param to rimraf
grypez 6d06bc5
build(shims): Harmonize bundle.js with node 18 & 20
grypez 7114e00
test(shims): Configure tests
grypez 576e29c
test(shims): Add minimal endoify shim test
grypez fdb97fa
refactor(shims): Abstract endo bundling of endo sources
grypez c8dea0e
feat(shims): Bundle endoify dependencies
grypez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import { HandledPromise } from '@endo/eventual-send'; | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| describe('endoified', () => { | ||
| it('calls lockdown', () => { | ||
| expect(Object.isFrozen(Array.prototype)).toBe(true); // Due to `lockdown()`, and therefore `ses` | ||
| }); | ||
|
|
||
| it('loads eventual-send', () => { | ||
| expect(typeof HandledPromise).not.toBe('undefined'); // Due to eventual send | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import type { Context } from 'node:vm'; | ||
| import type { Environment } from 'vitest/environments'; | ||
|
|
||
| export default { | ||
| name: 'endoified', | ||
| transformMode: 'ssr', | ||
| async setupVM() { | ||
| const vm = await import('node:vm'); | ||
| return { | ||
| getVmContext(): Context { | ||
| return vm.createContext({ | ||
| setTimeout, | ||
| clearTimeout, | ||
| }); | ||
| }, | ||
| // eslint-disable-next-line no-empty-function | ||
| teardown(): void {}, | ||
| }; | ||
| }, | ||
| async setup() { | ||
| throw new Error( | ||
| 'endoified environment requires vitest option --pool=vmThreads or --pool=vmForks', | ||
| ); | ||
| }, | ||
| } as Environment; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,23 @@ | ||
| // eslint-disable-next-line spaced-comment | ||
| /// <reference types="vitest" /> | ||
|
|
||
| import { defineConfig, mergeConfig } from 'vite'; | ||
|
|
||
| import { getDefaultConfig } from '../../vitest.config.packages.js'; | ||
|
|
||
| const config = getDefaultConfig(); | ||
| const defaultConfig = getDefaultConfig(); | ||
|
|
||
| const config = mergeConfig( | ||
| defaultConfig, | ||
| defineConfig({ | ||
| test: { | ||
| pool: 'vmThreads', | ||
| environment: './vitest-environment-endoified.ts', | ||
| setupFiles: '../dist/endoify.mjs', | ||
| }, | ||
| }), | ||
| ); | ||
|
|
||
| // @ts-expect-error We can and will delete this. | ||
| delete config.test.coverage.thresholds; | ||
| export default config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, this is equivalent and unoffensive to the linter: