fix: Issue 2115 Handle messages only coming from the main frame to prevent spoofing from child iframes #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing from child iframes
sethkfman
reviewed
Jun 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a potential spoofing approach: if the website has a child iFrame, this child iFrame can execute a request to your MetaMask wallet (send a message). Currently, we don't have a way to distinguish between messages from the main frame and from the child frame.
We discussed in Slack that for now the easiest solution will be to block requests from child iFrames. Later we can investigate how to display on the UI the origin of the request.
I've replicated the same behaviour on both platforms.