Skip to content

fix: Issue 2115 Handle messages only coming from the main frame to prevent spoofing from child iframes #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyschenko merged 1 commit into from
Jul 29, 2025
Merged

fix: Issue 2115 Handle messages only coming from the main frame to prevent spoofing from child iframes #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion android/src/main/java/com/reactnativecommunity/webview/RNCWebView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,9 @@ protected void createRNCWebViewBridge(RNCWebView webView) {
@Override
public void onPostMessage(@NonNull WebView view, @NonNull WebMessageCompat message,
@NonNull Uri sourceOrigin, boolean isMainFrame, @NonNull JavaScriptReplyProxy replyProxy) {
RNCWebView.this.onMessage(message.getData(), sourceOrigin.toString());
if (isMainFrame) {
RNCWebView.this.onMessage(message.getData(), sourceOrigin.toString());
}
}
};
WebViewCompat.addWebMessageListener(
Expand Down
2 changes: 1 addition & 1 deletion apple/RNCWebViewImpl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ - (void)userContentController:(WKUserContentController *)userContentController
_disablePromptDuringLoading = NO;
}
} else if ([message.name isEqualToString:MessageHandlerName]) {
if (_onMessage) {
if (_onMessage && message.frameInfo.mainFrame) {
NSMutableDictionary<NSString *, id> *event = [self baseEvent];
[event addEntriesFromDictionary: @{@"data": message.body}];
[event addEntriesFromDictionary: @{@"url": message.frameInfo.request.URL.absoluteString}];
Expand Down
Loading