Skip to content

deps: remove ethereumjs-util #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikoferro merged 5 commits into from
Apr 16, 2024
Merged

deps: remove ethereumjs-util #192

nikoferro merged 5 commits into from
Apr 16, 2024

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Feb 16, 2024 •
edited
Loading

Deprecated ethereumjs-util is only used for its library function addHexPrefix. The add0x function from @metamask/utils provides equivalent functionality.

  • fix: Remove dependency ethereumjs-util
    • Replace usage of addHexPrefix with add0x from @metamask/utils

@legobeat legobeat force-pushed the deps-remove-ethereumjs-util branch from 205cab7 to 86a7954 Compare February 16, 2024 10:28
@socket-security
Copy link

socket-security bot commented Feb 16, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/ethjs-query@0.5.3 Transitive: environment, eval, filesystem +13 4.32 MB lgbot

🚮 Removed packages: npm/@types/ethereumjs-util@6.1.0

View full report↗︎

@legobeat legobeat marked this pull request as ready for review February 16, 2024 10:29
@legobeat legobeat requested a review from dan437 as a code owner February 16, 2024 10:29
@legobeat legobeat requested review from a team, infiniteflower and nikoferro February 16, 2024 10:29
@legobeat legobeat mentioned this pull request Feb 16, 2024
Merged
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Feb 16, 2024
@legobeat legobeat force-pushed the deps-remove-ethereumjs-util branch from 86a7954 to 7ad66da Compare February 21, 2024 03:52
@legobeat
deps: remove ethereumjs-util
2cfd0ef 
- replace `addHexPrefix` with `add0x` from `@metamask/utils`
@legobeat
update allow-scripts config
7aabc36
@legobeat legobeat force-pushed the deps-remove-ethereumjs-util branch from 7ad66da to 7aabc36 Compare February 27, 2024 08:53
nikoferro
nikoferro previously approved these changes Apr 16, 2024
View reviewed changes
Copy link

@nikoferro nikoferro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikoferro nikoferro self-requested a review April 16, 2024 13:07
nikoferro
nikoferro approved these changes Apr 16, 2024
View reviewed changes
Copy link

@nikoferro nikoferro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikoferro nikoferro merged commit 00411fd into main Apr 16, 2024
@nikoferro nikoferro deleted the deps-remove-ethereumjs-util branch April 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dan437 dan437 Awaiting requested review from dan437

@infiniteflower infiniteflower Awaiting requested review from infiniteflower

1 more reviewer

@nikoferro nikoferro nikoferro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat @nikoferro