Bump @metamask/controllers from 26.0.0 to 33.0.0 #139

dependabot · 2022-11-09T06:09:15Z

Bumps @metamask/controllers from 26.0.0 to 33.0.0.

Release notes

Sourced from @metamask/controllers's releases.

33.0.0

Added

Add clear function for NotificationController (#943)

Changed

BREAKING: Rename "Collectible" to "NFT" (#934)

Rename CollectiblesController to NftController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".

Rename CollectibleDetectionController to NftDetectionController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".

Rename AssetsContractController method getERC721CollectibleTokenId to getERC721NftTokenId.

Rename assetsUtil method compareCollectiblesMetadata to compareNftMetadata.

Rename constant ASSET_TYPES.COLLECTIBLE to ASSET_TYPES.NFT

Rename PreferencesController state property useCollectibleDetection to useNftDetection

Rename PreferenceController method setUseCollectibleDetection to setUseNftDetection

Fixed

Fix NetworkController lookupNetwork deadlock (#948)

Fix invalid rpcTarget and nickname network state after switching from custom network to Infura network using setProviderType (#947)

32.0.2

Fixed

Fix issue introduced in v32.0.1 where EthQuery is not instantiated correctly on GasFeeController when constructed (#936)

32.0.1

Fixed

Make both callback and messaging system options for TokenListController & GasFeeController when listening to NetworkController (#932)

Add error handling when eth_estimateGas fails in TransactionController (#920)

32.0.0

Added

Add isOutOfDate to the PhishingController, for checking whether the phishing lists are out-of-date. (#929)

Changed

BREAKING: Make the PhishingController test synchronous (#929)

Rather than being polled regularly (as it was pre-v31), or updated on fetch (as in v31), the phishing lists are no longer updated automatically at all. You will need to manually call isOutOfDate to check whether they are out-of-date, and then call updatePhishingLists to update them.

BREAKING: Migrate NetworkController to BaseControllerV2 (#903)

There is no more "controller configuration" with BaseControllerV2. Instead configuration is set by constructor parameters.

The constructor accepts a single "options" object rather than separate parameters. The initial state is now passed as part of this options object, via the state property.

The constructor must be passed the infuraProjectId and messenger options. The messenger should be a restricted controller messenger.

Controller subscriptions must be registered through the controller messenger, rather than through the controller directly.

A providerChange event has been added. This is dispatched when the provider instance variable is updated.

When there is a network switch, this is dispatched after the network has been fully initialized.

A new getEthQuery action has been added, for obtaining an EthQuery instance that is already setup with the current provider

Note that it will stop working when the provider changes, so you should call this again each time the providerChange event is dispatched.

Fixed

Prevent parallel phishing configuration updates (#930)

Fix issues with empty responses in ERC20Standard (#927)

Calling getTokenSymbol and getTokenDecimals on contracts that return empty values (0x) for symbol() and decimals() will now throw an error.

31.2.0

... (truncated)

Changelog

Sourced from @metamask/controllers's changelog.

[33.0.0]

Added

Add clear function for NotificationController (#943)

Changed

BREAKING: Rename "Collectible" to "NFT" (#934)

Rename CollectiblesController to NftController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".

Rename CollectibleDetectionController to NftDetectionController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".

Rename AssetsContractController method getERC721CollectibleTokenId to getERC721NftTokenId.

Rename assetsUtil method compareCollectiblesMetadata to compareNftMetadata.

Rename constant ASSET_TYPES.COLLECTIBLE to ASSET_TYPES.NFT

Rename PreferencesController state property useCollectibleDetection to useNftDetection

Rename PreferenceController method setUseCollectibleDetection to setUseNftDetection

Fixed

Fix NetworkController lookupNetwork deadlock (#948)

Fix invalid rpcTarget and nickname network state after switching from custom network to Infura network using setProviderType (#947)

[32.0.2]

Fixed

Fix issue introduced in v32.0.1 where EthQuery is not instantiated correctly on GasFeeController when constructed (#936)

[32.0.1]

Fixed

Make both callback and messaging system options for TokenListController & GasFeeController when listening to NetworkController (#932)

Add error handling when eth_estimateGas fails in TransactionController (#920)

[32.0.0]

Added

Add isOutOfDate to the PhishingController, for checking whether the phishing lists are out-of-date. (#929)

Changed

BREAKING: Make the PhishingController test synchronous (#929)

Rather than being polled regularly (as it was pre-v31), or updated on fetch (as in v31), the phishing lists are no longer updated automatically at all. You will need to manually call isOutOfDate to check whether they are out-of-date, and then call updatePhishingLists to update them.

BREAKING: Migrate NetworkController to BaseControllerV2 (#903)

There is no more "controller configuration" with BaseControllerV2. Instead configuration is set by constructor parameters.

The constructor accepts a single "options" object rather than separate parameters. The initial state is now passed as part of this options object, via the state property.

The constructor must be passed the infuraProjectId and messenger options. The messenger should be a restricted controller messenger.

Controller subscriptions must be registered through the controller messenger, rather than through the controller directly.

A providerChange event has been added. This is dispatched when the provider instance variable is updated.

When there is a network switch, this is dispatched after the network has been fully initialized.

A new getEthQuery action has been added, for obtaining an EthQuery instance that is already setup with the current provider

Note that it will stop working when the provider changes, so you should call this again each time the providerChange event is dispatched.

Fixed

Prevent parallel phishing configuration updates (#930)

Fix issues with empty responses in ERC20Standard (#927)

Calling getTokenSymbol and getTokenDecimals on contracts that return empty values (0x) for symbol() and decimals() will now throw an error.

[31.2.0]

... (truncated)

Commits

dcb74f7 33.0.0 (#949)
b3635c9 Fix lookupNetwork deadlock (#948)
cf76cbd NetworkController setProviderType doesn't reset the rpcTarget and nickname (#...
c027807 Bump actions (#946)
8b2fc06 Use cached dependencies and immutable install during publish (#942)
af8ebf0 Add clear function for NotificationController (#943)
957d7df Bump actions (#944)
c2f3a8d Remove outdated sections from README (#937)
bdf76a6 Rename "Collectible" to "NFT" (#934)
14bb1be Lint, then build, then test (#939)
Additional commits viewable in compare view

Maintainer changes

This version was pushed to npm by metamaskbot, a new releaser for @metamask/controllers since your current version.

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

socket-security · 2022-11-09T06:10:34Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
New author	npm/async@2.6.4	New Author: hargasinski Previous Author: aearly	Source
New author	npm/istanbul-lib-report@3.0.1	New Author: oss-bot Previous Author: coreyfarrell	`package.json`
New author	npm/istanbul-lib-source-maps@4.0.1	New Author: oss-bot Previous Author: coreyfarrell	`package.json`
New author	npm/anymatch@3.1.3	New Author: phated Previous Author: paulmillr	`package.json`
New author	npm/fb-watchman@2.0.2	New Author: bolinfest Previous Author: wez	`package.json`
Network access	npm/https-proxy-agent@5.0.1	Module: net Location: Package overview	Source
Network access	npm/https-proxy-agent@5.0.1	Module: tls Location: Package overview	Source
New author	npm/asn1@0.2.6	New Author: bahamat Previous Author: melloc	`package.json`
Network access	npm/http-proxy-agent@5.0.0	Module: net Location: Package overview	`package.json`
Network access	npm/http-proxy-agent@5.0.0	Module: tls Location: Package overview	`package.json`
New author	npm/for-each@0.3.3	New Author: ljharb Previous Author: raynos	`package.json`
New author	npm/react-is@18.2.0	New Author: gnoff Previous Author: acdlite	`package.json`
New author	npm/tr46@3.0.0	New Author: domenic Previous Author: timothygu	`package.json`
Network access	npm/jsdom@20.0.3	Module: https Location: Package overview	`package.json`
Network access	npm/jsdom@20.0.3	Module: http-proxy-agent Location: Package overview	`package.json`
Network access	npm/jsdom@20.0.3	Module: https-proxy-agent Location: Package overview	`package.json`
New author	npm/querystringify@2.2.0	New Author: lpinca Previous Author: 3rdeden	`package.json`
New author	npm/fast-diff@1.3.0	New Author: luin Previous Author: dgreensp	`package.json`
New author	npm/http-signature@1.3.6	New Author: bahamat Previous Author: kusor	`package.json`
New author	npm/jsonify@0.0.1	New Author: ljharb Previous Author:	`package.json`
New author	npm/npm-normalize-package-bin@3.0.1	New Author: npm-cli-ops Previous Author: lukekarrys	Source
New author	npm/write-file-atomic@5.0.1	New Author: npm-cli-ops Previous Author: lukekarrys	`package.json`
New author	npm/which@3.0.1	New Author: npm-cli-ops Previous Author: lukekarrys	`package.json`
New author	npm/exponential-backoff@3.1.1	New Author: sssayegh Previous Author: coveo-organization	`package.json`
New author	npm/rlp@2.2.7	New Author: ralxz Previous Author: holgerd77	Source
Network access	npm/socks@2.7.1	Module: net Location: Package overview	`package.json`
Network access	npm/agentkeepalive@4.5.0	Module: http Location: Package overview	`package.json`
Network access	npm/agentkeepalive@4.5.0	Module: https Location: Package overview	`package.json`
New author	npm/@npmcli/fs@2.1.2	New Author: gar Previous Author: lukekarrys	`package.json`
Deprecated	npm/@npmcli/move-file@2.0.1	Reason: This functionality has been moved to @npmcli/fs	`package.json`
New author	npm/are-we-there-yet@3.0.1	New Author: lukekarrys Previous Author: gar	`package.json`
Network access	npm/make-fetch-happen@10.2.1	Module: http Location: Package overview	`package.json`
Network access	npm/make-fetch-happen@10.2.1	Module: http-proxy-agent Location: Package overview	`package.json`
Network access	npm/make-fetch-happen@10.2.1	Module: https-proxy-agent Location: Package overview	`package.json`
Network access	npm/make-fetch-happen@10.2.1	Module: http-cache-semantics Location: Package overview	`package.json`
Network access	npm/make-fetch-happen@10.2.1	Module: dns Location: Package overview	`package.json`
Network access	npm/make-fetch-happen@10.2.1	Module: globalThis["fetch"] Location: Package overview	`package.json`
Network access	npm/make-fetch-happen@10.2.1	Module: https Location: Package overview	`package.json`
Network access	npm/minipass-fetch@2.1.2	Module: globalThis["fetch"] Location: Package overview	`package.json`
Network access	npm/minipass-fetch@2.1.2	Module: http Location: Package overview	`package.json`
Network access	npm/minipass-fetch@2.1.2	Module: https Location: Package overview	`package.json`
New author	npm/nopt@6.0.0	New Author: gar Previous Author: isaacs	`package.json`
New author	npm/npmlog@6.0.2	New Author: lukekarrys Previous Author: gar	`package.json`
Network access	npm/socks-proxy-agent@7.0.0	Module: dns Location: Package overview	`package.json`
Network access	npm/socks-proxy-agent@7.0.0	Module: tls Location: Package overview	`package.json`
New author	npm/@npmcli/node-gyp@3.0.0	New Author: lukekarrys Previous Author: gar	`package.json`
New author	npm/read-cmd-shim@4.0.0	New Author: lukekarrys Previous Author: gar	`package.json`
New author	npm/@metamask/obs-store@7.0.0	New Author: gudahtt Previous Author: rekmarks	`package.json`
New author	npm/ethereumjs-wallet@1.0.2	New Author: ralxz Previous Author: holgerd77	`package.json`
New author	npm/@keystonehq/bc-ur-registry@0.5.5	New Author: liyanlance Previous Author: soralit	`package.json`
New author	npm/create-jest@29.7.0	New Author: simenb Previous Author: cpojer	`package.json`
New author	npm/unique-slug@3.0.0	New Author: lukekarrys Previous Author: zkat	`package.json`
New author	npm/assert@2.1.0	New Author: ljharb Previous Author: lukechilds	`package.json`
Network access	npm/@cypress/request@3.0.1	Module: http Location: Package overview	`package.json`
Network access	npm/@cypress/request@3.0.1	Module: http-signature Location: Package overview	`package.json`
Network access	npm/@cypress/request@3.0.1	Module: https Location: Package overview	`package.json`
New author	npm/cmd-shim@6.0.2	New Author: npm-cli-ops Previous Author: nlf	`package.json`
Network access	npm/web3-providers-http@4.1.0	Module: globalThis["fetch"] Location: Package overview	`package.json` <

legobeat · 2023-07-14T22:29:22Z

@dependabot rebase

dependabot · 2023-07-14T22:29:24Z

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

legobeat · 2023-07-14T22:30:23Z

@dependabot recreate

legobeat · 2023-07-14T22:36:25Z

@dan437 @meppsilon @sethkfman PTAL. This needs a bump of min nodejs version.

Updating @metamask/controllers andsiblings will be necessary to resolve some security issues.

This repo is currently set to private such that I don't seem to be able to clone or create pull requests right now.

socket-security · 2023-07-14T22:43:44Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/code-frame@7.23.5	Transitive: environment	`+10`	191 kB	nicolo-ribaudo
npm/@babel/core@7.23.9	environment, filesystem, unsafe Transitive: shell	`+52`	10.8 MB	nicolo-ribaudo
npm/@babel/generator@7.23.6	Transitive: environment	`+10`	3.38 MB	nicolo-ribaudo
npm/@babel/parser@7.23.9	None	`0`	1.88 MB	nicolo-ribaudo
npm/@babel/template@7.23.9	Transitive: environment	`+15`	4.59 MB	nicolo-ribaudo
npm/@babel/types@7.23.9	environment	`+3`	2.49 MB	nicolo-ribaudo
npm/@eslint-community/regexpp@4.10.0	None	`0`	431 kB	eslint-community-bot
npm/@ethereumjs/common@2.6.5	Transitive: environment, filesystem	`+43`	11.6 MB	holgerd77
npm/@ethereumjs/tx@3.5.2	Transitive: environment, filesystem	`+44`	12 MB	holgerd77
npm/@jridgewell/trace-mapping@0.3.22	None	`+2`	265 kB	jridgewell
npm/@lavamoat/allow-scripts@3.0.1	environment, filesystem, shell Transitive: network	`+121`	5.58 MB	naugtur
npm/@metamask/auto-changelog@2.6.1	Transitive: environment, filesystem, shell	`+33`	1.19 MB	gudahtt
npm/@metamask/controllers@33.0.0	network Transitive: environment, eval, filesystem, shell	`+326`	70.8 MB	metamaskbot
npm/@metamask/eslint-config-jest@12.1.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+461`	91.1 MB	metamaskbot
npm/@metamask/eslint-config-nodejs@12.1.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+199`	31.7 MB	metamaskbot
npm/@metamask/eslint-config-typescript@12.1.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+223`	108 MB	metamaskbot
npm/@metamask/eslint-config@12.2.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+191`	30.1 MB	metamaskbot
npm/@metamask/ethjs-query@0.5.2	Transitive: environment, eval, filesystem	`+13`	4.26 MB	lgbot
npm/@nodelib/fs.stat@2.0.5	filesystem	`0`	11.8 kB	mrmlnc
npm/@nodelib/fs.walk@1.2.8	Transitive: filesystem	`+6`	127 kB	mrmlnc
npm/@types/babel__traverse@7.20.5	Transitive: environment	`+4`	2.58 MB	types
npm/@types/istanbul-lib-coverage@2.0.6	None	`0`	5.45 kB	types
npm/@types/node@20.11.16	None	`+1`	4.06 MB	types
npm/@typescript-eslint/eslint-plugin@5.62.0	Transitive: environment, eval, filesystem, shell, unsafe	`+127`	48.3 MB	jameshenry
npm/@typescript-eslint/parser@5.62.0	Transitive: environment, eval, filesystem, shell, unsafe	`+119`	45.1 MB	jameshenry
npm/@typescript-eslint/utils@5.62.0	Transitive: environment, eval, filesystem, shell, unsafe	`+123`	45.7 MB	jameshenry
npm/acorn-walk@8.3.2	None	`0`	52.4 kB	marijn
npm/acorn@8.11.3	None	`0`	531 kB	marijn
npm/ansi-regex@5.0.1	None	`0`	5.61 kB	qix
npm/array-buffer-byte-length@1.0.1	Transitive: eval	`+12`	245 kB	ljharb
npm/async-mutex@0.3.2	None	`+1`	134 kB	dirtyhairy
npm/async@2.6.4	None	`0`	541 kB	hargasinski
npm/available-typed-arrays@1.0.6	None	`0`	20.4 kB	ljharb
npm/bignumber.js@9.1.2	None	`0`	351 kB	mikemcl
npm/bn.js@5.2.1	None	`0`	99 kB	fanatid
npm/call-bind@1.0.6	Transitive: eval	`+10`	214 kB	ljharb
npm/crc-32@1.2.2	None	`0`	31 kB	sheetjs
npm/define-data-property@1.1.2	Transitive: eval	`+8`	173 kB	ljharb
npm/define-properties@1.2.1	Transitive: eval	`+10`	212 kB	ljharb
npm/es-abstract@1.22.3	Transitive: eval	`+57`	3.26 MB	ljharb
npm/es-errors@1.3.0	None	`0`	12.3 kB	ljharb
npm/eslint-config-prettier@8.10.0	Transitive: environment, eval, filesystem, shell, unsafe	`+96`	10.7 MB	lydell
npm/eslint-plugin-import@2.26.0	filesystem, unsafe Transitive: environment, eval, network, shell	`+174`	15.9 MB	ljharb
npm/eslint-plugin-jest@27.6.3	filesystem Transitive: environment, eval, network, shell, unsafe	`+372`	72 MB	simenb
npm/eslint-plugin-jsdoc@43.2.0	Transitive: environment, eval, filesystem, shell, unsafe	`+105`	13.3 MB	gajus
npm/eslint-plugin-n@15.7.0	filesystem Transitive: environment, eval, shell, unsafe	`+110`	12.6 MB	weiran.zsd
npm/eslint-plugin-prettier@4.2.1	Transitive: environment, eval, filesystem, shell, unsafe	`+99`	22.1 MB	jounqin
npm/eslint-plugin-promise@6.1.1	Transitive: environment, eval, filesystem, shell, unsafe	`+96`	10.8 MB	eslint-community-bot
npm/eslint-visitor-keys@3.4.3	None	`0`	32.3 kB	eslintbot
npm/eslint@8.56.0	environment, filesystem Transitive: eval, shell, unsafe	`+95`	10.7 MB	eslintbot
npm/espree@9.6.1	None	`+3`	662 kB	eslintbot
npm/esquery@1.5.0	None	`+1`	1.04 MB	michaelficarra
npm/estraverse@5.3.0	None	`0`	37.1 kB	michaelficarra
npm/ethereumjs-util@7.1.5	Transitive: environment, filesystem	`+41`	8.99 MB	holgerd77
npm/get-intrinsic@1.2.4	eval	`+5`	124 kB	ljharb
npm/glob@7.2.3	filesystem Transitive: environment	`+10`	145 kB	isaacs
npm/graceful-fs@4.2.11	environment, filesystem	`0`	32.5 kB	isaacs
npm/has-bigints@1.0.2	None	`0`	12.8 kB	ljharb
npm/has-property-descriptors@1.0.1	Transitive: eval	`+6`	135 kB	ljharb
npm/has-symbols@1.0.3	None	`0`	20.6 kB	ljharb
npm/has-tostringtag@1.0.2	None	`+1`	38.2 kB	ljharb
npm/https-proxy-agent@5.0.1	network Transitive: environment	`+2`	75.2 kB	tootallnate
npm/iconv-lite@0.6.3	None	`+1`	391 kB	ashtuchkin
npm/ignore@5.3.1	None	`0`	51.5 kB	kael
npm/is-array-buffer@3.0.4	Transitive: eval	`+11`	231 kB	ljharb
npm/is-callable@1.2.7	None	`0`	28.9 kB	ljharb
npm/is-core-module@2.13.1	None	`+2`	72.5 kB	ljharb
npm/is-glob@4.0.3	None	`+1`	19.8 kB	phated
npm/is-string@1.0.7	None	`+2`	57.3 kB	ljharb
npm/is-symbol@1.0.4	None	`+1`	42.6 kB	ljharb
npm/is-typed-array@1.1.13	Transitive: eval	`+16`	358 kB	ljharb
npm/istanbul-lib-coverage@3.2.2	None	`0`	34.4 kB	oss-bot
npm/jest-environment-jsdom@29.7.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+100`	14.5 MB	simenb
npm/jest-util@29.7.0	environment Transitive: filesystem	`+18`	4.88 MB	simenb
npm/jest@29.7.0	Transitive: environment, eval, filesystem, network, shell, unsafe	`+287`	56.7 MB	simenb
npm/mime-types@2.1.35	None	`+1`	224 kB	dougwilson
npm/minimist@1.2.8	None	`0`	54.5 kB	ljharb
npm/minipass@3.3.6	None	`0`	48.1 kB	isaacs
npm/node-fetch@2.7.0	network	`+6`	891 kB	node-fetch-bot
npm/npm-normalize-package-bin@3.0.1	None	`0`	3.58 kB	npm-cli-ops
npm/p-limit@3.1.0	None	`+1`	13.8 kB	sindresorhus
npm/parse5@7.1.2	None	`+1`	1.11 MB	feedic
npm/picomatch@2.3.1	None	`0`	90 kB	mrmlnc
npm/prettier@2.8.8	environment, filesystem, unsafe	`0`	11.2 MB	prettier-bot
npm/punycode@2.3.1	None	`0`	33.5 kB	google-wombot
npm/resolve@1.22.8	environment, filesystem	`+5`	232 kB	ljharb
npm/rlp@2.2.7	None	`+1`	162 kB	ralxz
npm/secp256k1@4.0.3	Transitive: environment, filesystem	`+9`	2.9 MB	fanatid
npm/semver@7.6.0	None	`+1`	110 kB	npm-cli-ops
npm/signal-exit@3.0.7	None	`0`	9.96 kB	isaacs
npm/string-width@4.2.3	None	`+4`	68 kB	sindresorhus
npm/strip-ansi@6.0.1	None	`+1`	9.64 kB	sindresorhus
npm/tar@6.2.0	environment, filesystem	`+7`	354 kB	isaacs
npm/tough-cookie@4.1.3	None	`+6`	690 kB	awaterma
npm/ts-jest@29.1.2	environment, filesystem, unsafe Transitive: eval, network, shell	`+290`	57.1 MB	kul
npm/ts-node@10.9.2	environment, filesystem, unsafe	`+19`	38.1 MB	blakeembrey
npm/tslib@2.6.2	None	`0`	84 kB	typescript-bot
npm/typescript@5.3.3	None	`0`	32 MB	typescript-bot
npm/web3-core@4.3.2	Transitive: environment, eval, filesystem, network	`+53`	13.4 MB	luu-alex
npm/web3-errors@1.1.4	None	`+1`	694 kB	jdevcs
npm/web3-eth-accounts@4.1.1	Transitive: environment, eval	`+34`	7.45 MB	luu-alex
npm/web3-eth-contract@4.2.0	Transitive: environment, eval, filesystem, network	`+61`	48.1 MB	luu-alex
npm/web3-eth@4.4.0	Transitive: environment, eval, filesystem, network	`+60`	47.7 MB	luu-alex
npm/web3-rpc-methods@1.1.4	Transitive: environment, eval, filesystem, network	`+54`	13.5 MB	luu-alex
npm/web3-types@1.3.1	None	`0`	290 kB	jdevcs
npm/web3-utils@4.1.1	Transitive: environment, eval	`+31`	6.01 MB	luu-alex
npm/web3-validator@2.0.4	Transitive: environment, eval	`+30`	5.48 MB	luu-alex
npm/web3@4.4.0	Transitive: environment, eval, filesystem, network	`+65`	52.2 MB	luu-alex
npm/which-typed-array@1.1.14	Transitive: eval	`+15`	335 kB	ljharb
npm/yargs-parser@21.1.1	environment, filesystem	`0`	128 kB	oss-bot

View full report↗︎

legobeat · 2023-10-17T04:46:12Z

@nikoferro

legobeat · 2023-11-22T11:53:18Z

@dan437 Minimum Node.js version has been increased to 16 (#173), which should allow bumping here.

legobeat · 2023-11-22T11:54:53Z

@dependabot recreate

Bumps [@metamask/controllers](https://github.com/MetaMask/controllers) from 26.0.0 to 33.0.0. - [Release notes](https://github.com/MetaMask/controllers/releases) - [Changelog](https://github.com/MetaMask/controllers/blob/main/CHANGELOG.md) - [Commits](MetaMask/core@v26.0.0...v33.0.0) --- updated-dependencies: - dependency-name: "@metamask/controllers" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

davibroc

I am testing it now with mobile

legobeat · 2023-12-06T20:16:12Z

I am testing it now with mobile

The types do not pass build, though?
https://github.com/MetaMask/swaps-controller/actions/runs/7062382351/job/19226072611

$ tsc --project .
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,81): error TS1005: ',' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,90): error TS1109: Expression expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,96): error TS1005: ')' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,114): error TS1005: ';' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,130): error TS1005: ';' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,131): error TS1128: Declaration or statement expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,137): error TS1109: Expression expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(15,5): error TS1128: Declaration or statement expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(15,29): error TS1005: ',' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(15,68): error TS1109: Expression expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(15,80): error TS1005: ';' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(22,5): error TS1128: Declaration or statement expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(22,35): error TS1005: ',' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(22,59): error TS1109: Expression expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(22,71): error TS1005: ';' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(32,5): error TS1128: Declaration or statement expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(32,34): error TS1005: ',' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(32,60): error TS1011: An element access expression should take an argument.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(32,73): error TS1109: Expression expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(32,85): error TS1005: ';' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(33,1): error TS1128: Declaration or statement expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(109,5): error TS1131: Property or signature expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(109,9): error TS1005: ';' expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(109,24): error TS1005: ';' expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(110,9): error TS1005: ';' expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(110,28): error TS1005: ',' expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(124,13): error TS1109: Expression expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(128,26): error TS1109: Expression expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(132,18): error TS1109: Expression expected.
Error: node_modules/web3-types/lib/commonjs/eth_contract_types.d.ts(133,1): error TS1128: Declaration or statement expected.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 2.

davibroc · 2023-12-07T09:53:50Z

I am testing it now with mobile

The types do not pass build, though? https://github.com/MetaMask/swaps-controller/actions/runs/7062382351/job/19226072611
$ tsc --project .
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,81): error TS1005: ',' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,90): error TS1109: Expression expected.

I am able to build the PR locally with this command yarn && yarn build && yarn pack --filename <file-path>

From the mobile repo I then add the package with yarn add <file-path> but when I run yarn setup I get the following error Error: Patch file found for package bip39 which is not present at node_modules/bip39

Any idea why?

legobeat · 2023-12-07T10:35:07Z

I am testing it now with mobile

The types do not pass build, though? https://github.com/MetaMask/swaps-controller/actions/runs/7062382351/job/19226072611
$ tsc --project .
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,81): error TS1005: ',' expected.
Error: node_modules/web3-eth-accounts/lib/commonjs/tx/transactionFactory.d.ts(8,90): error TS1109: Expression expected.
I am able to build the PR locally with this command yarn && yarn build && yarn pack --filename <file-path>

From the mobile repo I then add the package with yarn add <file-path> but when I run yarn setup I get the following error Error: Patch file found for package bip39 which is not present at node_modules/bip39

Any idea why?

Hm, the build fails locally for me with the same errors as in CI (typescript errors in web3-eth-acounts).
Have you tried wiping your node_modules? Can you post build output?

Re the bip39 thing: It's trying to patch a package which is no longer present (as eth-keyring-controller@^6.2.1 is no longer pulled in after this upgrade. you should be able to observe this from the yarn.lock diff). So in general it's either one of that patch needing to be ported, or no longer being necessary.

klejeune · 2023-12-07T16:17:45Z

Typing issues have been fixed by upgrading the Typescript version. Jest has some issues running the tests though.

…rules

nikoferro · 2024-01-16T13:48:38Z

Currently working on this, had to update dependencies since we werent able to run the linter with the new rules that are extended from @metamask/eslint-config. Last commit fixes all the linting errors after the updates. Still need to fix jest

…ndabot/npm_and_yarn/main/metamask/controllers-33.0.0

nikoferro · 2024-02-01T09:22:39Z

@dan437 @davibroc hey guys, this should be ready to test and merge if everything goes well, we got some socket security alerts, but i think those are safe to ignore. can you review this PR?

dan437

Code-wise it looks good. Let's wait for a QA approval before merging.

…ndabot/npm_and_yarn/main/metamask/controllers-33.0.0

legobeat · 2024-02-16T10:31:11Z

Follow-ups:

dependabot bot requested review from a team and meppsilon as code owners November 9, 2022 06:09

dependabot bot added the dependencies Pull requests that update a dependency file label Nov 9, 2022

dependabot bot mentioned this pull request Nov 9, 2022

Bump @metamask/controllers from 26.0.0 to 32.0.2 #137

Closed

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch from a10bfaa to 4f3678c Compare November 18, 2022 16:37

dependabot bot requested a review from dan437 as a code owner November 18, 2022 16:37

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch 2 times, most recently from 4b30668 to 155fa49 Compare November 21, 2022 13:53

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch 2 times, most recently from 544cb97 to c216dc3 Compare December 1, 2022 20:45

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch 2 times, most recently from 8e6375d to ee62fa5 Compare December 12, 2022 09:13

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch 2 times, most recently from bc0bf3b to f6b328c Compare December 21, 2022 14:41

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch from f6b328c to 1edb8f3 Compare January 9, 2023 14:22

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch from 1edb8f3 to 73a4d28 Compare January 24, 2023 12:44

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch from 73a4d28 to 4b2e541 Compare July 14, 2023 22:31

legobeat assigned nikoferro Oct 17, 2023

legobeat assigned dan437 Nov 9, 2023

dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch from 4b2e541 to e5768ae Compare November 22, 2023 11:55

klejeune added 2 commits November 29, 2023 23:56

chore: update lavamoat

c90bb71

fix: build

ea7c6ca

davibroc previously approved these changes Dec 6, 2023

View reviewed changes

klejeune dismissed davibroc’s stale review via ea7c6ca December 7, 2023 16:14

chore: update dependencies and fix linting issues due to new linting …

c630523

…rules

nikoferro added 4 commits January 17, 2024 16:10

chore: updating web3 mock, and adding missing peer dep

0d556c3

chore: replaced fetch-mock as it wasnt working with our latest deps

0cbcb26

Merge branch 'main' of github.com:MetaMask/swaps-controller into depe…

a67127c

…ndabot/npm_and_yarn/main/metamask/controllers-33.0.0

chore: update gas api url on tests and tests for providers

4e170fe

nikoferro requested a review from davibroc February 1, 2024 09:22

dan437 previously approved these changes Feb 1, 2024

View reviewed changes

Merge branch 'main' of github.com:MetaMask/swaps-controller into depe…

8f01ba0

…ndabot/npm_and_yarn/main/metamask/controllers-33.0.0

nikoferro dismissed dan437’s stale review via 8f01ba0 February 7, 2024 10:32

nikoferro requested a review from dan437 February 7, 2024 10:37

dan437 approved these changes Feb 15, 2024

View reviewed changes

nikoferro merged commit 3e6db87 into main Feb 15, 2024

nikoferro deleted the dependabot/npm_and_yarn/main/metamask/controllers-33.0.0 branch February 15, 2024 16:27

legobeat mentioned this pull request Feb 16, 2024

deps: replace @metamask/controllers with individual controller packages #193

Merged

This was referenced Apr 16, 2024

Remove dependency on eth-query #179

Closed

Remove dependency on ethjs-query #180

Closed

Remove dependency on web3.js v0.x #178

Closed

legobeat mentioned this pull request May 11, 2024

Write comprehensive unit tests #159

Open

AnnFlynn-csi unassigned nikoferro Oct 29, 2024

Bump @metamask/controllers from 26.0.0 to 33.0.0 #139

Bump @metamask/controllers from 26.0.0 to 33.0.0 #139

Uh oh!

Conversation

dependabot bot commented on behalf of github Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

33.0.0

Added

Changed

Fixed

32.0.2

Fixed

32.0.1

Fixed

32.0.0

Added

Changed

Fixed

31.2.0

[33.0.0]

Added

Changed

Fixed

[32.0.2]

Fixed

[32.0.1]

Fixed

[32.0.0]

Added

Changed

Fixed

[31.2.0]

Uh oh!

socket-security bot commented Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legobeat commented Jul 14, 2023

Uh oh!

dependabot bot commented on behalf of github Jul 14, 2023

Uh oh!

legobeat commented Jul 14, 2023

Uh oh!

legobeat commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legobeat commented Oct 17, 2023

Uh oh!

legobeat commented Nov 22, 2023

Uh oh!

legobeat commented Nov 22, 2023

Uh oh!

davibroc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

legobeat commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davibroc commented Dec 7, 2023

Uh oh!

legobeat commented Dec 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

klejeune commented Dec 7, 2023

Uh oh!

nikoferro commented Jan 16, 2024

Uh oh!

nikoferro commented Feb 1, 2024

Uh oh!

dan437 left a comment

Choose a reason for hiding this comment

Uh oh!

legobeat commented Feb 16, 2024

Uh oh!

Reviewers

Assignees

Labels

dependabot bot commented on behalf of github Nov 9, 2022 •

edited

Loading

socket-security bot commented Nov 9, 2022 •

edited

Loading

legobeat commented Jul 14, 2023 •

edited

Loading

socket-security bot commented Jul 14, 2023 •

edited

Loading

davibroc left a comment •

edited

Loading

legobeat commented Dec 6, 2023 •

edited

Loading

legobeat commented Dec 7, 2023 •

edited

Loading