deps: replace @metamask/controllers with individual controller packages

[legobeat]

• Follow-up to Bump @metamask/controllers from 26.0.0 to 33.0.0 #139
• Replace obsolete dependency @metamask/controllers with:
  • @metamask/base-controller
  • @metamask/composable-controller
  • @metamask/controller-utils
    • Note: This dependency is now duplicated (v8 used since Bump @metamask/controllers from 26.0.0 to 33.0.0 #139; v2 pulled in transitively here)
  • @metamask/gas-fee-controller (devDep; for types only)
  • @metamask/transaction-controller (devDep; for types only)
    • Inline now unexported normalizeTransaction from @metamask/transaction-controller
• Resolves: CVE-2023-46233 / GHSA-xwcq-pm8m-c4vf

The dependencies added as part of this PR use older versions to keep the changes in the PR down. Upgrading them to newer version requires further work and can be addressed in a further follow-up.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/code-frame@7.24.2	environment	+11	199 kB	nicolo-ribaudo
npm/@babel/core@7.24.4	environment, filesystem, unsafe Transitive: shell	+28	5.2 MB	nicolo-ribaudo
npm/@babel/generator@7.24.4	None	+3	624 kB	nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.0	None	0	11.7 kB	nicolo-ribaudo
npm/@babel/parser@7.24.4	None	0	1.88 MB	nicolo-ribaudo
npm/@babel/template@7.24.0	None	0	68.9 kB	nicolo-ribaudo
npm/@babel/types@7.24.0	environment	+3	2.5 MB	nicolo-ribaudo
npm/@jridgewell/resolve-uri@3.1.2	None	0	53.2 kB	jridgewell
npm/@jridgewell/trace-mapping@0.3.25	None	0	169 kB	jridgewell
npm/@lavamoat/allow-scripts@3.0.4	environment Transitive: filesystem, network, shell	+66	3.56 MB	boneskull
npm/@metamask/base-controller@1.1.2	Transitive: environment, network	+7	1.61 MB	metamaskbot
npm/@metamask/composable-controller@1.0.2	None	0	14.3 kB	metamaskbot
npm/@metamask/controller-utils@8.0.4	network Transitive: filesystem	+10	2.81 MB	metamaskbot
npm/@metamask/gas-fee-controller@3.0.0	Transitive: environment, eval, filesystem, network	+111	14.6 MB	metamaskbot
npm/@metamask/transaction-controller@3.0.0	Transitive: environment, eval, filesystem, network	+127	22.8 MB	metamaskbot
npm/@scure/base@1.1.6	None	0	80.4 kB	paulmillr
npm/@types/node@20.12.7	None	+1	2.1 MB	types
npm/builtins@5.1.0	None	0	3.7 kB	juliangruber
npm/call-bind@1.0.7	None	+4	87.8 kB	ljharb
npm/define-data-property@1.1.4	None	+2	50.4 kB	ljharb
npm/es-abstract@1.23.3	None	+44	3.28 MB	ljharb
npm/eslint-plugin-jest@27.9.0	filesystem	0	325 kB	simenb
npm/eslint@8.57.0	environment, filesystem Transitive: eval, unsafe	+49	7.98 MB	eslintbot
npm/glob@10.3.12	Transitive: environment, filesystem, shell	+15	2.03 MB	isaacs
npm/has-property-descriptors@1.0.2	None	+1	22.7 kB	ljharb
npm/has-proto@1.0.3	None	0	12 kB	ljharb
npm/hasown@2.0.2	None	+1	40.2 kB	ljharb
npm/is-shared-array-buffer@1.0.3	None	0	18.7 kB	ljharb
npm/lru-cache@10.2.0	None	0	458 kB	isaacs
npm/minipass@7.0.4	None	0	285 kB	isaacs
npm/string-width@5.1.2	None	+4	127 kB	sindresorhus
npm/tar@6.2.1	environment, filesystem	+4	275 kB	isaacs
npm/typescript@5.4.5	None	0	32.4 MB	typescript-bot
npm/web3-eth@4.5.0	Transitive: environment, network	+10	3.15 MB	jdevcs
npm/web3-rpc-methods@1.2.0	None	0	135 kB	jdevcs
npm/web3-utils@4.2.2	None	+4	1.11 MB	luu-alex
npm/web3-validator@2.0.5	Transitive: environment, eval	+7	1.54 MB	luu-alex
npm/web3@4.7.0	Transitive: environment, network	+16	6.54 MB	luu-alex
npm/which-typed-array@1.1.15	None	+4	92.7 kB	ljharb

🚮 Removed packages: npm/@babel/code-frame@7.23.5, npm/@babel/core@7.23.9, npm/@babel/generator@7.23.6, npm/@babel/helper-plugin-utils@7.22.5, npm/@babel/parser@7.23.9, npm/@babel/template@7.23.9, npm/@babel/types@7.23.9, npm/@jridgewell/gen-mapping@0.3.3, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/trace-mapping@0.3.22, npm/@lavamoat/allow-scripts@3.0.1, npm/@metamask/controller-utils@8.0.3, npm/@scure/base@1.1.5, npm/@types/node@20.11.16, npm/available-typed-arrays@1.0.6, npm/call-bind@1.0.6, npm/define-data-property@1.1.2, npm/es-abstract@1.22.3, npm/eslint-plugin-jest@27.6.3, npm/eslint@8.56.0, npm/has-property-descriptors@1.0.1, npm/tar@6.2.0, npm/typescript@5.3.3, npm/web3-eth-contract@4.2.0, npm/web3-eth@4.4.0, npm/web3-rpc-methods@1.1.4, npm/web3-types@1.3.1, npm/web3-utils@4.2.1, npm/web3-validator@2.0.4, npm/web3@4.4.0, npm/which-typed-array@1.1.14

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
New author	npm/validate-npm-package-name@5.0.0	New Author: lukekarrys Previous Author: gar	package.json
Shell access	npm/foreground-child@3.1.1	Module: child_process Location: Package overview	Source
Shell access	npm/foreground-child@3.1.1	Module: child_process Location: Package overview	Source
New author	npm/nopt@7.2.0	New Author: npm-cli-ops Previous Author: gar	package.json
New author	npm/abbrev@2.0.0	New Author: lukekarrys Previous Author: isaacs	package.json
New author	npm/normalize-package-data@6.0.0	New Author: npm-cli-ops Previous Author: lukekarrys	package.json
New author	npm/diff@5.2.0	New Author: explodingcabbage Previous Author: kpdecker	package.json
New author	npm/superstruct@1.0.4	New Author: artmllr Previous Author: ianstormtaylor	package.json
Network access	npm/socks-proxy-agent@8.0.3	Module: net Location: Package overview	package.json
Network access	npm/agent-base@7.1.1	Module: https Location: Package overview	package.json
Network access	npm/agent-base@7.1.1	Module: http Location: Package overview	package.json
Network access	npm/agent-base@7.1.1	Module: net Location: Package overview	package.json
Network access	npm/@npmcli/agent@2.2.2	Module: net Location: Package overview	package.json
Network access	npm/@npmcli/agent@2.2.2	Module: tls Location: Package overview	package.json
Network access	npm/@npmcli/agent@2.2.2	Module: dns Location: Package overview	package.json
Network access	npm/@npmcli/agent@2.2.2	Module: http-proxy-agent Location: Package overview	package.json
Network access	npm/@npmcli/agent@2.2.2	Module: https-proxy-agent Location: Package overview	package.json
Unstable ownership	npm/proc-log@4.1.0	Author: npm-cli-ops	package.json

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/validate-npm-package-name@5.0.0
• @SocketSecurity ignore npm/foreground-child@3.1.1
• @SocketSecurity ignore npm/nopt@7.2.0
• @SocketSecurity ignore npm/abbrev@2.0.0
• @SocketSecurity ignore npm/normalize-package-data@6.0.0
• @SocketSecurity ignore npm/diff@5.2.0
• @SocketSecurity ignore npm/superstruct@1.0.4
• @SocketSecurity ignore npm/socks-proxy-agent@8.0.3
• @SocketSecurity ignore npm/agent-base@7.1.1
• @SocketSecurity ignore npm/@npmcli/agent@2.2.2
• @SocketSecurity ignore npm/proc-log@4.1.0

[legobeat]

@nikoferro It seems that bcadd60 and d2ac36 messed this up a bit - after the merge here it still pulls in @metamask/controllers which is not the intention with this PR.

EDIT: Addressed in #214