Rewrite Triangulation<T> storage: raw arrays + ReadOnlyMemory, stackalloc, ref mutations#9
Merged
MichaConrad merged 2 commits intomainfrom Feb 22, 2026
Conversation
…loc, ref mutations Co-authored-by: MichaCo <5837539+MichaCo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor triangulation for optimized memory management
Rewrite Triangulation<T> storage: raw arrays + ReadOnlyMemory, stackalloc, ref mutations
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the three
List<T>backing stores with raw arrays + explicit count fields, exposing contiguous-memory read-only views and eliminating unnecessary copies throughout the hot paths.Storage & public API
List<V2d<T>>→V2d<T>[] + int _verticesCount;Verticesnow returnsReadOnlyMemory<V2d<T>>List<Triangle>→Triangle[] + int _trianglesCount;Trianglesnow returnsReadOnlyMemory<Triangle>List<int> _vertTris→int[] + int _vertTrisCountArrayEnsureCapacityon first insertion; doubling growth viaArrayAddstackalloc
InsertVertices_RandomizedandInsertVertices_KDTreeBFSusestackalloc int[n]whenn ≤ StackAllocThreshold (512), falling back to heap otherwise.NthElementchanged fromint[]toSpan<int>.ref mutations — eliminate copy-back pattern
All read-modify-write triangle mutations converted from the
var t = …; mutate; _triangles[i] = tpattern toref var t = ref _triangles[i]:ChangeNeighboroverloadsTriangulatePseudoPolygonIteration(was doing 4–6 round-trips per call)RemoveTrianglesneighbor remapping loopFinalizeTriangulationvertex-offset loopSpan-based utilities
VertexXComparer/VertexYComparertakeV2d<T>[]directly — removesIReadOnlyList<T>interface dispatch on every compareBox2d<T>.Envelop(ReadOnlySpan<V2d<T>>)overload added; used inInitKdTreeCdtUtils.ExtractEdgesFromTrianglesandCalculateTrianglesByVertexacceptReadOnlySpan<Triangle>withref readonlyinner loopsTopologyVerifierworks off.Spanfrom both memory properties🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.