Skip to content

Rewrite Triangulation<T> storage: raw arrays + ReadOnlyMemory, stackalloc, ref mutations #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaConrad merged 2 commits into from
Feb 22, 2026
Merged

Rewrite Triangulation<T> storage: raw arrays + ReadOnlyMemory, stackalloc, ref mutations #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed97799
Initial plan
Copilot Feb 22, 2026
d9eb0ab
Rewrite Triangulation memory layout: arrays + ReadOnlyMemory, stackal…
Copilot Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/CDT.Core/CdtUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ public static void RemapEdges(List<Edge> edges, IReadOnlyList<int> mapping)
// -------------------------------------------------------------------------

/// <summary>Extracts all unique edges from a triangle list.</summary>
/// <param name="triangles">The triangle list to extract edges from.</param>
/// <param name="triangles">The triangles to extract edges from.</param>
/// <returns>A set containing all unique edges in the triangulation.</returns>
public static HashSet<Edge> ExtractEdgesFromTriangles(IReadOnlyList<Triangle> triangles)
public static HashSet<Edge> ExtractEdgesFromTriangles(ReadOnlySpan<Triangle> triangles)
{
var edges = new HashSet<Edge>(triangles.Count * 3);
foreach (var t in triangles)
var edges = new HashSet<Edge>(triangles.Length * 3);
foreach (ref readonly var t in triangles)
{
edges.Add(new Edge(t.V0, t.V1));
edges.Add(new Edge(t.V1, t.V2));
Expand All @@ -167,12 +167,12 @@ public static HashSet<Edge> ExtractEdgesFromTriangles(IReadOnlyList<Triangle> tr
/// A read-only list of read-only lists: for each vertex index, the list of adjacent triangle indices.
/// </returns>
public static IReadOnlyList<IReadOnlyList<int>> CalculateTrianglesByVertex(
IReadOnlyList<Triangle> triangles,
ReadOnlySpan<Triangle> triangles,
int verticesCount)
{
var result = new List<int>[verticesCount];
for (int i = 0; i < verticesCount; i++) result[i] = new List<int>();
for (int i = 0; i < triangles.Count; i++)
for (int i = 0; i < triangles.Length; i++)
{
var t = triangles[i];
result[t.V0].Add(i);
Expand Down
10 changes: 5 additions & 5 deletions src/CDT.Core/TopologyVerifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ public static class TopologyVerifier
public static bool VerifyTopology<T>(Triangulation<T> cdt)
where T : unmanaged, IFloatingPoint<T>, IMinMaxValue<T>, IRootFunctions<T>
{
var triangles = cdt.Triangles;
var vertices = cdt.Vertices;
var triangles = cdt.Triangles.Span;
var vertices = cdt.Vertices.Span;

for (int iT = 0; iT < triangles.Count; iT++)
for (int iT = 0; iT < triangles.Length; iT++)
{
var t = triangles[iT];
// Verify non-invalid vertices
if (t.V0 == Indices.NoVertex || t.V1 == Indices.NoVertex || t.V2 == Indices.NoVertex)
return false;
if (t.V0 >= vertices.Count || t.V1 >= vertices.Count || t.V2 >= vertices.Count)
if (t.V0 >= vertices.Length || t.V1 >= vertices.Length || t.V2 >= vertices.Length)
return false;
// No degenerate (same-vertex) triangles
if (t.V0 == t.V1 || t.V1 == t.V2 || t.V0 == t.V2)
Expand All @@ -39,7 +39,7 @@ public static bool VerifyTopology<T>(Triangulation<T> cdt)
{
int iN = t.GetNeighbor(i);
if (iN == Indices.NoNeighbor) continue;
if (iN >= triangles.Count) return false;
if (iN >= triangles.Length) return false;
var tN = triangles[iN];
// Neighbor must reference us back
if (tN.N0 != iT && tN.N1 != iT && tN.N2 != iT)
Expand Down
Loading