Add view to run experiments based on a given entity version

[skeating]

Fixes #67.

[codecov-io]

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #138   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files          50     50           
  Lines        2069   2069           
  Branches      224    224           
=====================================
  Hits         1966   1966           
  Misses         76     76           
  Partials       27     27

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a66d6...f9e07bf. Read the comment docs.

[codecov-io]

Codecov Report

Merging #138 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #138     +/-   ##
=======================================
+ Coverage    91.8%    92%   +0.1%     
=======================================
  Files          60     60             
  Lines        2418   2465     +47     
  Branches      253    262      +9     
=======================================
+ Hits         2222   2269     +47     
  Misses        169    169             
  Partials       27     27

Impacted Files	Coverage Δ
weblab/entities/urls.py	100% <ø> (ø)	⬆️
weblab/entities/templatetags/entities.py	100% <100%> (ø)	⬆️
weblab/entities/views.py	94.1% <100%> (+0.5%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e883b33...a4dbf1c. Read the comment docs.

[jonc125]

Hi Sarah. Some initial thoughts from a quick read-through; hope they're helpful!

[jonc125]

This could do with a test that the view now works with a non-latest version of 'this_entity', but apart from that I think it's ready to merge.

[jonc125]

Note there are some fixes for this now as part of #185, so we'll need to cherry-pick those into this branch before merging. Relevant commits are I think 74c5b77, 7e4d598, 3208fc6.

Also, given the speed of this view at the workshop was a little slow and the display was rather long, we might want to make a couple of extra changes.

• More compact display. E.g. here, I think we want ideally 2 lines per version, something like:
  • <a><b>tag</b> <small>(sha...)</small></a> <small>by Author created date-time</small>
  • <small>commit message</small>
    It may need some style="display: inline;" attributes added on the small elements?
• See if we can reduce the number of DB queries needed (and especially make sure no calls to git are made) - if you have LOG_DEBUG=True you should see queries output. Play with select_related and prefetch_related.

[skeating]

Okay I cannot change the code that loads the runexperiments view to not grab commits from the repo - and this will be heavy hitting as it queries each version of each entity !
See #191 for more detailed explanation.

I also cannot work out a way of fetching the commits without hitting the repo. I can get cachedentities with some of the information but I need the actual commit object for the hrefs call to url functions.

I accept I may be missing something but have spent some time playing with various queries etc and cannot see it.

[skeating]

I would claim this done - again :-)

[jonc125]

It just needs a test adding (or more likely modify one of the existing tests) to demonstrate that the view now works with a non-latest version of 'this_entity'.

[skeating]

Might really be done this time :-)

[jonc125]

Yep :)