Skip to content

Hacky version of fitting spec support#185

Merged
jonc125 merged 88 commits intomasterfrom
182-fitting-specs
Jul 14, 2019
Merged

Hacky version of fitting spec support#185
jonc125 merged 88 commits intomasterfrom
182-fitting-specs

Conversation

@jonc125
Copy link
Copy Markdown
Contributor

@jonc125 jonc125 commented May 30, 2019

Will fix #182.

Also includes aspects of #137, #131.

It is hacky and completely untested! We should consider what needs to be done to tidy this up before merge, or possibly post-merge to enable cleaner review.

Some clear outstanding tasks, which may become separate PRs, in rough priority order:

  • Add tests for the new features, especially around data upload & view.
  • Fix any bugs revealed!
    • For some reason the dataset description is not being set
  • Respect dataset visibility - e.g. at present anyone can overlay other users' private datasets. Possibly they can link their data to private protocols as well; I'm not sure.
  • Link fitting specs to datasets (and via that to a protocol) so a 'fitting spec' protocol only contains the actual fitting specification. We definitely don't want to do that as part of this PR. It may get subsumed by longer term planning for how this will be architected, e.g. when FittingSpec becomes a concept in its own right.

skeating added 30 commits May 9, 2019 11:22
I know need to work out getting the checkboxes/buttons to something and then replicate for global models/protocols
@jonc125
Copy link
Copy Markdown
Contributor Author

jonc125 commented Jun 12, 2019

Added another issue I spotted to the description.

@skeating
Copy link
Copy Markdown
Contributor

Currently the description is part of the file upload page. This is inconsistent with 'description' for other files upload which is on the creation page. It is probably an easier fix to move the field :-)

@jonc125
Copy link
Copy Markdown
Contributor Author

jonc125 commented Jun 17, 2019

Currently the description is part of the file upload page. This is inconsistent with 'description' for other files upload which is on the creation page. It is probably an easier fix to move the field :-)

Fine by me!

@jonc125 jonc125 marked this pull request as ready for review July 14, 2019 20:18
@jonc125
Copy link
Copy Markdown
Contributor Author

jonc125 commented Jul 14, 2019

I'm merging this to master so it can be deployed on scrambler and stop it being broken!

@jonc125 jonc125 merged commit dfed6f1 into master Jul 14, 2019
@jonc125 jonc125 deleted the 182-fitting-specs branch July 14, 2019 20:19
@jonc125 jonc125 mentioned this pull request Aug 12, 2019
6 tasks
MauriceHendrix pushed a commit that referenced this pull request Jul 22, 2021
Hacky version of fitting spec support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hacky support for fitting specs

3 participants