Conversation
I know need to work out getting the checkboxes/buttons to something and then replicate for global models/protocols
…o my vagrant deployment will
…7-add-view-run-exp
…n interaction with the js
Contributor
Author
|
Added another issue I spotted to the description. |
Contributor
|
Currently the description is part of the file upload page. This is inconsistent with 'description' for other files upload which is on the creation page. It is probably an easier fix to move the field :-) |
Contributor
Author
Fine by me! |
Contributor
Author
|
I'm merging this to master so it can be deployed on scrambler and stop it being broken! |
MauriceHendrix
pushed a commit
that referenced
this pull request
Jul 22, 2021
Hacky version of fitting spec support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will fix #182.
Also includes aspects of #137, #131.
It is hacky and completely untested! We should consider what needs to be done to tidy this up before merge, or possibly post-merge to enable cleaner review.
Some clear outstanding tasks, which may become separate PRs, in rough priority order:
FittingSpecbecomes a concept in its own right.