added validation on tagname#286
Merged
sroderick-g5sro merged 3 commits intomasterfrom Sep 22, 2020
Merged
Conversation
jonc125
requested changes
Sep 16, 2020
| tag = forms.CharField( | ||
| help_text='Optional short label for this version', | ||
| required=False) | ||
| required=False, validators=[RegexValidator(r'[-_A-Za-z0-9]', 'Please enter a valid tag name.')]) |
Contributor
There was a problem hiding this comment.
Just a stylistic thing: it's best practice to have each arg on a separate line when they don't all fit on one.
Suggested change
| required=False, validators=[RegexValidator(r'[-_A-Za-z0-9]', 'Please enter a valid tag name.')]) | |
| required=False, | |
| validators=[RegexValidator(r'[-_A-Za-z0-9]', 'Please enter a valid tag name.')]) |
Contributor
There was a problem hiding this comment.
The other occurrence is done, but you missed this one :)
Contributor
Author
There was a problem hiding this comment.
sorry, changed that now
| label='New tag', | ||
| help_text='Short label for this version', | ||
| required=True) | ||
| required=True, validators=[RegexValidator(r'[-_A-Za-z0-9]', 'Please enter a valid tag name.')]) |
Contributor
There was a problem hiding this comment.
Suggested change
| required=True, validators=[RegexValidator(r'[-_A-Za-z0-9]', 'Please enter a valid tag name.')]) | |
| required=True, | |
| validators=[RegexValidator(r'[-_A-Za-z0-9]', 'Please enter a valid tag name.')]) |
MauriceHendrix
pushed a commit
that referenced
this pull request
Jul 22, 2021
added validation on tagname
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #261.