Skip to content

added validation on tagname #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sroderick-g5sro merged 3 commits into from
Sep 22, 2020
Merged

added validation on tagname #286

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f013ca
added validation on tagname
sroderick-g5sro Sep 16, 2020
2701ff8
Changed tag validation message
sroderick-g5sro Sep 22, 2020
4f5d82d
Changed tag validation message
sroderick-g5sro Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions weblab/entities/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from braces.forms import UserKwargModelFormMixin
from django import forms
from django.core.exceptions import ValidationError
from django.core.validators import RegexValidator
from django.forms import formset_factory

from accounts.models import User
Expand Down Expand Up @@ -57,7 +58,9 @@ class EntityVersionForm(forms.Form):
)
tag = forms.CharField(
help_text='Optional short label for this version',
required=False)
required=False,
validators=[RegexValidator(r'[-_A-Za-z0-9]', 'Please enter a valid tag name. '
'Only letters, numbers, dashes or underscores are allowed.' )])
commit_message = forms.CharField(
label='Description of this version',
widget=forms.Textarea)
Expand Down Expand Up @@ -94,7 +97,9 @@ class EntityTagVersionForm(forms.Form):
tag = forms.CharField(
label='New tag',
help_text='Short label for this version',
required=True)
required=True,
validators=[RegexValidator(r'[-_A-Za-z0-9]', 'Please enter a valid tag name.'
' Only letters, numbers, dashes or underscores are allowed.')])


class EntityCollaboratorForm(forms.Form):
Expand Down