Conversation
Note that these have variables with the same names but different ids.
tamuri
left a comment
There was a problem hiding this comment.
Looks good. Well-formed, MathML valid and transpiler works, RDF valid. We can check the various connections/annotations as we develop. Out of interest, the CellML XML schema has for connection type:
<xsd:element name="connection" type="connection_type" />
<xsd:complexType name="connection_type">
<xsd:choice maxOccurs="unbounded" >
<xsd:element ref="map_components" />
<xsd:element ref="map_variables" />
</xsd:choice>
</xsd:complexType>
Therefore, this test model (and the weblab cellml examples I looked at) doesn't validate with schema.
|
I'm aware that the XML Schema for CellML 1 doesn't capture all restrictions, but I thought it would at least validate things that were valid. Though I've not tried it in years. I checked the files with pycml and it says they're OK, which I trust much more :) Though I don't see why the snippet you showed would fail to validate - doesn't the maxOccurs on the choice let you have more than 1 of each? So it's really too lenient (you should have at most one |
|
|
|
Not if the |
|
If the |
|
Ah, yes, that's right. |
Thanks & confirmed, validates with the Relax NG schema from https://chaste.comlab.ox.ac.uk/cellml/ |
For #21. I think this is now a fairly complete set of tests for the CellML parsing side of things.