Configuration: Samples Sheet validation#243
Merged
taimontgomery merged 5 commits intomasterfrom Oct 22, 2022
Merged
Conversation
…t. This code is substantially cleaner and validation is more thorough. Super satisfying.
…it can also be used in unit_tests_configuration.py. I've also changed column names in the tests so that they match the internal shortnames that we use. This makes things a little more succinct and I think it makes more sense. Now, the same identifier is used to refer to a column both in is pre- and post- parsed form.
Member
Author
|
This update should also be included in the upcoming release; please merge prior to PR #241 |
Collaborator
|
Tested successfully with ram1 data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new class, SamplesSheet, has been added to configuration.py. It acts as a basic API to the Configuration class and validates the contents of the user's Samples Sheet. If the following requirements are not met, it is treated as a hard error and pipeline execution halts at startup:
If the following requirements are not met, a warning is printed and pipeline execution continues:
Closes #242