New range order UX #253

grunch · 2025-08-02T20:57:59Z

✅ Implementation Complete

🎯 New User Experience

Initial State: Single input with "Enter amount you want to receive"
Progressive Reveal: Second input appears with "to" + "Max amount" placeholder after typing first digit
Smart Guidance: Shows "💡 Tap the second field to create a range order" tip
Range Mode: Activates when user taps second field → "Range Order" badge appears, title changes to "Creating a range order..."

🔧 Technical Implementation

Enhanced AmountSection Widget

✅ Converted to StatefulWidget with sophisticated state management
✅ Progressive UI that reveals complexity gradually
✅ Smart focus detection for range mode activation
✅ Dual TextEditingController management with proper validation
✅ Clean integration with existing FormSection

Improved FormSection Component

✅ Added topRightWidget parameter for "Range Order" badge
✅ Maintains backward compatibility with existing usage

Streamlined AddOrderScreen Integration

✅ Removed complex string parsing (_parseFiatAmount)
✅ Direct structured data handling with (int? minAmount, int? maxAmount)
✅ Cleaner state management and validation

Comprehensive Localization

✅ English: "Enter amount you want to receive", "Range Order", etc.
✅ Spanish: "Ingresa la cantidad que quieres recibir", "Orden de Rango", etc.
✅ Italian: "Inserisci l'importo che vuoi ricevere", "Ordine Intervallo", etc.

🛡️ Robust Validations

✅ Numbers Only: Both inputs accept only digits
✅ Smart Validation: Max amount must be greater than min amount
✅ Progressive Validation: Validates as user types
✅ Clean Reset: Clearing first input resets entire component state

🎨 Intuitive Design

✅ Kid-Friendly: Simple, progressive disclosure of functionality
✅ Visual Feedback: Clear indicators for range mode with badge and title changes
✅ Helpful Hints: Contextual guidance text
✅ Accessible: Works for all age groups as requested

The new UX transforms the confusing "1000-2000" manual entry into an intuitive, guided experience that naturally leads users from simple to advanced functionality. Users can now create both regular orders (single amount) and range orders (min-max amounts) through a seamless, progressive interface! 🚀

Summary by CodeRabbit

New Features
- Introduced explicit support for creating range orders with separate input fields for minimum and maximum amounts.
- Added dynamic UI elements, such as a "Range Order" badge and contextual tips, when entering range amounts.
- Form sections can now display an optional widget in the top-right corner of their header.
Improvements
- Amount entry is now clearer, with dedicated fields and improved validation for minimum and maximum values.
- Localization strings updated in English, Spanish, and Italian to provide clearer instructions and validation for both single and range order entries.
Removals
- Removed the previous currency range text field widget and associated parsing logic.

✅ Implementation Complete 🎯 New User Experience - Initial State: Single input with "Enter amount you want to receive" - Progressive Reveal: Second input appears with "to" + "Max amount" placeholder after typing first digit - Smart Guidance: Shows "💡 Tap the second field to create a range order" tip - Range Mode: Activates when user taps second field → "Range Order" badge appears, title changes to "Creating a range order..." 🔧 Technical Implementation 1. Enhanced AmountSection Widget - ✅ Converted to StatefulWidget with sophisticated state management - ✅ Progressive UI that reveals complexity gradually - ✅ Smart focus detection for range mode activation - ✅ Dual TextEditingController management with proper validation - ✅ Clean integration with existing FormSection 2. Improved FormSection Component - ✅ Added topRightWidget parameter for "Range Order" badge - ✅ Maintains backward compatibility with existing usage 3. Streamlined AddOrderScreen Integration - ✅ Removed complex string parsing (_parseFiatAmount) - ✅ Direct structured data handling with (int? minAmount, int? maxAmount) - ✅ Cleaner state management and validation 4. Comprehensive Localization - ✅ English: "Enter amount you want to receive", "Range Order", etc. - ✅ Spanish: "Ingresa la cantidad que quieres recibir", "Orden de Rango", etc. - ✅ Italian: "Inserisci l'importo che vuoi ricevere", "Ordine Intervallo", etc. 🛡️ Robust Validations - ✅ Numbers Only: Both inputs accept only digits - ✅ Smart Validation: Max amount must be greater than min amount - ✅ Progressive Validation: Validates as user types - ✅ Clean Reset: Clearing first input resets entire component state 🎨 Intuitive Design - ✅ Kid-Friendly: Simple, progressive disclosure of functionality - ✅ Visual Feedback: Clear indicators for range mode with badge and title changes - ✅ Helpful Hints: Contextual guidance text - ✅ Accessible: Works for all age groups as requested The new UX transforms the confusing "1000-2000" manual entry into an intuitive, guided experience that naturally leads users from simple to advanced functionality. Users can now create both regular orders (single amount) and range orders (min-max amounts) through a seamless, progressive interface! 🚀

coderabbitai · 2025-08-02T20:58:09Z

Walkthrough

The amount entry UI for creating orders was refactored from a single text field supporting range input to two dedicated fields for minimum and maximum amounts. The AmountSection widget is now stateful, with separate controllers and validation for each field. Localization strings were updated to reflect the new explicit range order flow, and unused currency text field code was removed.

Changes

Cohort / File(s)	Change Summary
Order Screen Logic & UI `lib/features/order/screens/add_order_screen.dart`	Replaced fiat amount parsing method to accept explicit min/max integers; updated to use new `AmountSection` API; removed obsolete controller and parsing logic.
Amount Section Refactor `lib/features/order/widgets/amount_section.dart`	Refactored from stateless to stateful widget; split single input into two fields for min/max; added state management, validation, range mode, and updated callback signature; updated UI to reflect explicit range entry and dynamic hints.
Form Section Enhancement `lib/features/order/widgets/form_section.dart`	Added optional `topRightWidget` property to allow insertion of a widget in the section header; updated constructor and build logic accordingly.
Localization: English `lib/l10n/intl_en.arb`	Simplified amount entry prompts; removed range examples from basic hints; added new strings for explicit range orders, new validation messages, and dynamic UI labels.
Localization: Spanish `lib/l10n/intl_es.arb`	Updated prompts and hints to remove implicit range references; added new strings for explicit range order support and validation.
Localization: Italian `lib/l10n/intl_it.arb`	Simplified amount prompts and validation; removed implicit range input hints; added new strings for explicit range order creation and validation.
Removed Currency Text Field Widget `lib/shared/widgets/currency_text_field.dart`	Deleted the `CurrencyTextField` widget and its state class, which previously handled parsing and validation for single/range currency input; removed all related public APIs.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AmountSection (Widget)
    participant AddOrderScreen (State)
    
    User->>AmountSection: Enter min amount
    AmountSection->>AmountSection: Validate min input
    AmountSection->>User: Show max field if min entered
    User->>AmountSection: Enter max amount (optional)
    AmountSection->>AmountSection: Validate max > min
    AmountSection->>AddOrderScreen: onAmountChanged(min, max)
    AddOrderScreen->>AddOrderScreen: Update state with min/max

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~35 minutes

Suggested reviewers

AndreaDiazCorreia

Poem

Two fields now greet the user's gaze,
For min and max, in separate ways.
The range is clear, the hint is neat,
Old widgets gone, new flows complete.
From single lines to double cheer—
This bunny hops, the path is clear! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbc215d and fc91244.

📒 Files selected for processing (4)

lib/features/order/widgets/amount_section.dart (1 hunks)
lib/l10n/intl_en.arb (1 hunks)
lib/l10n/intl_es.arb (1 hunks)
lib/l10n/intl_it.arb (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (4)

lib/l10n/intl_es.arb
lib/l10n/intl_en.arb
lib/l10n/intl_it.arb
lib/features/order/widgets/amount_section.dart

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/improve-range-order-creation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

lib/features/order/widgets/amount_section.dart (1)
89-103: Consider using const constructor for the badge Container.

The Container widget and its child Text can be made const since they don't depend on runtime values.
-      return Container(
+      return const Container(
         padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 4),
         decoration: BoxDecoration(
           color: const Color(0xFF8CC63F),
           borderRadius: BorderRadius.circular(12),
         ),
         child: Text(
           S.of(context)!.rangeOrder,
-          style: const TextStyle(
+          style: TextStyle(
             color: Colors.black,
             fontSize: 12,
             fontWeight: FontWeight.w500,
           ),
         ),
       );
Wait, I need to reconsider - the Text widget uses S.of(context)!.rangeOrder which is a runtime value, so the Container cannot be const.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccb4757 and cbc215d.

📒 Files selected for processing (7)

lib/features/order/screens/add_order_screen.dart (2 hunks)
lib/features/order/widgets/amount_section.dart (1 hunks)
lib/features/order/widgets/form_section.dart (3 hunks)
lib/l10n/intl_en.arb (1 hunks)
lib/l10n/intl_es.arb (1 hunks)
lib/l10n/intl_it.arb (1 hunks)
lib/shared/widgets/currency_text_field.dart (0 hunks)

💤 Files with no reviewable changes (1)

lib/shared/widgets/currency_text_field.dart

🧰 Additional context used

📓 Path-based instructions (5)

lib/features/*/{screens,providers,notifiers,widgets}/**/*.dart