Added condition to display Range Order badge #256

grunch · 2025-08-03T09:40:04Z

Changes Made:

Updated Badge Display Logic: Modified _getTopRightWidget() to check both conditions:

_isRangeMode (user has focused the second input)
_maxAmountController.text.isNotEmpty (second input has actual content)

Added Real-time Updates:

Added listener to _maxAmountController in initState()
Created _onMaxAmountChanged() method to trigger rebuilds when max amount content changes
Removed redundant onChanged callback from max amount TextFormField

User Experience Flow:

User types in first input → second input appears
User taps/focuses second input → range mode activates but badge doesn't show yet
User types in second input → "Range Order" badge appears
User deletes content from second input → badge disappears (indicates regular order)
User types again in second input → badge reappears

Technical Implementation:

Badge only shows when _isRangeMode && _maxAmountController.text.isNotEmpty
Real-time updates through controller listener ensure immediate visual feedback
Clean separation between focus detection (range mode) and content validation (badge display)

The Range Order badge now provides accurate visual feedback that reflects the actual order type being created.

Summary by CodeRabbit

Bug Fixes
- Improved UI updates when changing the max amount input to ensure accurate and timely feedback.
- Adjusted display logic so the "range order" badge only appears when in range mode and the max amount field is filled, preventing premature badge display.

Changes Made: 1. Updated Badge Display Logic: Modified _getTopRightWidget() to check both conditions: - _isRangeMode (user has focused the second input) - _maxAmountController.text.isNotEmpty (second input has actual content) 2. Added Real-time Updates: - Added listener to _maxAmountController in initState() - Created _onMaxAmountChanged() method to trigger rebuilds when max amount content changes - Removed redundant onChanged callback from max amount TextFormField User Experience Flow: 1. User types in first input → second input appears 2. User taps/focuses second input → range mode activates but badge doesn't show yet 3. User types in second input → "Range Order" badge appears 4. User deletes content from second input → badge disappears (indicates regular order) 5. User types again in second input → badge reappears Technical Implementation: - Badge only shows when _isRangeMode && _maxAmountController.text.isNotEmpty - Real-time updates through controller listener ensure immediate visual feedback - Clean separation between focus detection (range mode) and content validation (badge display) The Range Order badge now provides accurate visual feedback that reflects the actual order type being created.

coderabbitai · 2025-08-03T09:40:09Z

Walkthrough

The update modifies the behavior of the amount input section in the order feature. It introduces a listener to the max amount text controller, ensuring UI updates and notifications occur when the max amount changes. The logic for displaying the "range order" badge is also refined to depend on both range mode and non-empty max amount input.

Changes

Cohort / File(s)	Change Summary
Amount Section Widget Logic `lib/features/order/widgets/amount_section.dart`	Added a listener to the max amount controller for UI updates and notifications; introduced `_onMaxAmountChanged`; refined badge display condition.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant AmountSectionWidget
  participant MaxAmountController

  User->>MaxAmountController: Edit max amount input
  MaxAmountController-->>AmountSectionWidget: Triggers _onMaxAmountChanged listener
  AmountSectionWidget->>AmountSectionWidget: setState() (rebuild UI)
  AmountSectionWidget->>AmountSectionWidget: _notifyAmountChanged()
  AmountSectionWidget->>AmountSectionWidget: Evaluate badge display condition

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

New range order UX #253: Refines the range order UX in the same widget, with related logic for controller listeners and badge display.

Poem

A nibble here, a tweak just so,
The max amount now lets us know—
When numbers change, the badge appears,
Only when the field is clear.
With every hop, the UI’s bright,
Rabbits code by day and night! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96a3a8e and 0e347bf.

📒 Files selected for processing (1)

lib/features/order/widgets/amount_section.dart (3 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

lib/features/*/{screens,providers,notifiers,widgets}/**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

Feature-based organization: features/{feature}/{screens|providers|notifiers|widgets}/

Files:

lib/features/order/widgets/amount_section.dart

lib/**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

lib/**/*.dart: Use S.of(context).yourKey for all user-facing strings
Always use localized strings instead of hardcoded text
Pass BuildContext to methods that need localization
Always use latest APIs (e.g., withValues() instead of withOpacity())
Always check mounted before using context after async operations

Files:

lib/features/order/widgets/amount_section.dart

**/*.dart

📄 CodeRabbit Inference Engine (CLAUDE.md)

**/*.dart: Remove unused imports and dependencies
Use const constructors where possible

Files:

lib/features/order/widgets/amount_section.dart

🔇 Additional comments (3)

lib/features/order/widgets/amount_section.dart (3)

37-38: LGTM! Proper listener setup for real-time badge updates.

The max amount controller listener is correctly added in initState() with a clear comment explaining its purpose. The listener is properly disposed of in the dispose() method, preventing memory leaks.

68-72: LGTM! Clean implementation for badge state management.

The _onMaxAmountChanged() method correctly triggers UI rebuilds when the max amount changes and maintains consistency with the existing _onMinAmountChanged() pattern. Using setState(() {}) for triggering rebuilds is appropriate here.

101-101: LGTM! Precise badge display condition implemented.

The updated condition _isRangeMode && _maxAmountController.text.isNotEmpty correctly implements the PR objective of showing the Range Order badge only when both range mode is active AND the max amount field contains text. This prevents premature badge display and provides accurate visual feedback.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/range-order-badge-conditional-display

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

grunch merged commit 8d75a79 into main Aug 3, 2025
2 checks passed

grunch deleted the fix/range-order-badge-conditional-display branch August 3, 2025 09:42

coderabbitai bot mentioned this pull request Aug 20, 2025

Range validation feature in Add Order screen #273

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added condition to display Range Order badge #256

Added condition to display Range Order badge #256

Uh oh!

grunch commented Aug 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Added condition to display Range Order badge #256

Added condition to display Range Order badge #256

Uh oh!

Conversation

grunch commented Aug 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

grunch commented Aug 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)