This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Sort transactions in rust rather than in javascript#189
Merged
AnthonyRonning merged 1 commit intoMutinyWallet:masterfrom Dec 6, 2022
benthecarman:fix-sort
Merged
Sort transactions in rust rather than in javascript#189AnthonyRonning merged 1 commit intoMutinyWallet:masterfrom benthecarman:fix-sort
AnthonyRonning merged 1 commit intoMutinyWallet:masterfrom
benthecarman:fix-sort
Conversation
3 tasks
AnthonyRonning
approved these changes
Dec 6, 2022
danielabrozzoni
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Dec 19, 2022
d3d0756 Implement ordering for TransactionDetails (benthecarman) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description Pulled from MutinyWallet/mutiny-node#189 Wallets should be able to sort the transactions easily, this makes it so you can just all `sort` on a list of tx details instead of needing to implement the sort_by yourself ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: danielabrozzoni: utACK d3d0756 Tree-SHA512: d2b53dc959897b71d71794f3c919f86f8b7886e6ea5f6ac511cfaca0c19b2f78784a23491b3010380cf41da7ef69fd9ca1be75437c53eca1c60bd6651d1fec41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before my on-chain txs were jumping around in ordering. Tried to fix in the javascript sort function but kept getting issues (not sure why, maybe javascript number stuff). Changed to sort from the rust code and it fixed, this is probably better in the long run anyways