Implement ordering for TransactionDetails

[benthecarman]

Description

Pulled from MutinyWallet/mutiny-node#189

Wallets should be able to sort the transactions easily, this makes it so you can just all sort on a list of tx details instead of needing to implement the sort_by yourself

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[tnull]

Maybe it would make sense to implement Ord also for BlockTime, which would first compare the height then the timestamp. Here we then can just to compare the entire confirmation_time?

[benthecarman]

Good idea, done

[tnull]

I think you can make this (and below) quite a bit more concise by chaining the cmps via then_with.

Btw., Ord is implemented for Option<T>, so you should be able to just do self.confirmation_time.cmp(&other.confirmation_time).then_with(...), no need for the match.

[benthecarman]

Done, thanks!

[tnull]

Looks good to me.

[tnull]

Ah, this probably would also benefit from a really basic unit test checking that the ordering works as expected.

[benthecarman]

Added a test

[tnull]

Looks good from my side!

[notmandatory]

Looks like a good reasonable default ordering scheme to me. But you need to fix a clippy error, and rebase to fix a recent CI issue.

[benthecarman]

Looks like a good reasonable default ordering scheme to me. But you need to fix a clippy error, and rebase to fix a recent CI issue.

fixed

[danielabrozzoni]

utACK d3d0756

Thanks for taking care of this! :)