Add EML object as an alternative option for metadata_path #85
Merged
jagoldstein merged 16 commits intoNCEAS:masterfrom May 14, 2018
Merged
Add EML object as an alternative option for metadata_path #85jagoldstein merged 16 commits intoNCEAS:masterfrom
jagoldstein merged 16 commits intoNCEAS:masterfrom
Conversation
maier-m
suggested changes
May 9, 2018
| @@ -367,6 +367,15 @@ publish_update <- function(mn, | |||
| # Get the metadata doc | |||
| message("Getting metadata from the MN.") | |||
| eml <- EML::read_eml(rawToChar(dataone::getObject(mn, metadata_pid)), asText = TRUE) | |||
Contributor
There was a problem hiding this comment.
Need to close this if statement correct? or better use else if
Added `cache: packages` back in
@isteves helpfully noted that the Travis CI builds started failing a while ago in NCEAS#86. The failures indicate issues with Ubuntu PPAs and nothing to do with our tools. Though this happened around the time R 3.5.0 was released, which is a backwards incompatible R release indue to the introduction of ALTREP. This is: 1. My attempt to fix that so all the Travis builds pass 2. Reduce the deps arcticdatautils requires to install. ncdf4 and yaml are not packages that _need_ to be installed to get started using it so they should be in Suggests
amoeba
reviewed
May 10, 2018
| #' @param parent_child_pids (character) Optional. Resource map identifier(s) of child packages in the parent package. \code{resource_map_pid} should not be included. Not optional if the parent package contains other child packages. | ||
| #' @param child_pids (character) Optional. Child packages resource map PIDs. | ||
| #' @param metadata_path (character) Optional. Path to a metadata file to update with. If this is not set, the existing metadata document will be used. | ||
| #' @param metadata_path (character or eml) Optional. An eml class object or a path to a metadata file to update with. If this is not set, the existing metadata document will be used. |
Contributor
There was a problem hiding this comment.
Can/should this arg name get changed now that it's not just a path?
Contributor
Author
There was a problem hiding this comment.
I didn't want to change the name so that it could remain backwards-compatible. But if our preference is to make it friendlier for new users, then a name change makes sense
Contributor
There was a problem hiding this comment.
Yeah that's probably more important.
Reduce dependencies on ncdf4 and yaml Also fix travis build
Added `cache: packages` back in
…tautils into publish_update2
Contributor
Author
|
Updated with @amoeba's Travis changes so that Travis is 😺 |
maier-m
reviewed
May 14, 2018
|
|
||
| } else if(class(metadata_path) == "eml") { | ||
| # If an eml object is provided, use it directly after validating | ||
| if(!eml_validate(metadata_path)){ |
Contributor
There was a problem hiding this comment.
@isteves Maybe move this out of the call here so that eml always gets validated wether or not is an R object or from disk. Also maybe add a message so users know that eml is being validated in case it takes a non-trivial amount of time.
laijasmine
pushed a commit
that referenced
this pull request
Oct 2, 2020
Add EML object as an alternative option for metadata_path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to publish_update to also accept EML objects