Skip to content

Allow py3.12#61

Merged
felixhekhorn merged 10 commits into
mainfrom
remove-py-upper-limit
Feb 28, 2024
Merged

Allow py3.12#61
felixhekhorn merged 10 commits into
mainfrom
remove-py-upper-limit

Conversation

@felixhekhorn
Copy link
Copy Markdown
Contributor

No description provided.

@felixhekhorn felixhekhorn added the dependencies Pull requests that update a dependency file label Feb 27, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06%. Comparing base (e16d9b0) to head (79b5066).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   70.06%   70.06%           
=======================================
  Files          15       15           
  Lines         912      912           
=======================================
  Hits          639      639           
  Misses        273      273           
Flag Coverage Δ
unittests 70.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixhekhorn felixhekhorn changed the title Lift upper limit on Python Allow py3.12 Feb 27, 2024
@felixhekhorn
Copy link
Copy Markdown
Contributor Author

numpy/numpy#24810

Comment thread pyproject.toml
@felixhekhorn
Copy link
Copy Markdown
Contributor Author

@alecandido shall we merge?

@alecandido
Copy link
Copy Markdown
Collaborator

For me, it's fine:

  • Poetry managed to resolve dependencies and lock
  • the tests are passing

I'm not sure whether you want to eagerly try some benchmarks, or just wait for them to break (if ever) before attempting a fix.

@felixhekhorn felixhekhorn merged commit 38df78f into main Feb 28, 2024
@delete-merged-branch delete-merged-branch Bot deleted the remove-py-upper-limit branch February 28, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants