Skip to content

Allow py 3.12#349

Merged
felixhekhorn merged 5 commits into
masterfrom
add-py312
Feb 28, 2024
Merged

Allow py 3.12#349
felixhekhorn merged 5 commits into
masterfrom
add-py312

Conversation

@felixhekhorn
Copy link
Copy Markdown
Collaborator

Closes #348

cc @scarlehoff

@felixhekhorn felixhekhorn added the dependencies Pull requests that update a dependency file label Feb 27, 2024
@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

waiting for NNPDF/banana#61

@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

@alecandido if you have time, take a look - else I use you as trigger for LHA 🙃

@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

For future reference: we needed to port the changes from NNPDF/banana#61 to here - which are:

  • drop support for python 3.8
  • use pandas >2
  • use pylint >3.1

in addition, I set numba > 0.59 (which is out since 4 weeks) as I failed here and a simple update seemed to solve the issue ...

@alecandido
Copy link
Copy Markdown
Collaborator

This is reasonable, because ekomark not only depends on banana, but uses those tools directly (to play with banana objects of course, but the dependency is explicitly imported).

So, it should be sensible, since with ekomark you really have banana around. We should just stop the ekomark propagation downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release for py 3.12

2 participants