Skip to content

Set separate_multiplicative as False by default#2107

Merged
RoyStegeman merged 5 commits into
masterfrom
separate_multiplicative_to_false
Jun 18, 2024
Merged

Set separate_multiplicative as False by default#2107
RoyStegeman merged 5 commits into
masterfrom
separate_multiplicative_to_false

Conversation

@scarlehoff
Copy link
Copy Markdown
Member

As agreed.

As far as I am aware most projects had already sampling::separate_multiplicative = False in their runcards anyway.

@scarlehoff scarlehoff requested a review from andreab1997 June 6, 2024 11:58
@scarlehoff scarlehoff added the redo-regressions Recompute the regression data label Jun 6, 2024
@scarlehoff scarlehoff marked this pull request as ready for review June 6, 2024 13:43
@scarlehoff scarlehoff added run-fit-bot Starts fit bot from a PR. and removed redo-regressions Recompute the regression data labels Jun 7, 2024
@scarlehoff
Copy link
Copy Markdown
Member Author

This works and all test passed (including regressions!) @RoyStegeman feel free to apply extra changes before merging

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2024

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

@scarlehoff scarlehoff removed the run-fit-bot Starts fit bot from a PR. label Jun 8, 2024
@RoyStegeman RoyStegeman force-pushed the separate_multiplicative_to_false branch from 9e4e68c to 4d5360b Compare June 18, 2024 10:23
@RoyStegeman RoyStegeman merged commit 6e0cfe1 into master Jun 18, 2024
@RoyStegeman RoyStegeman deleted the separate_multiplicative_to_false branch June 18, 2024 12:14
@scarlehoff scarlehoff mentioned this pull request Jul 25, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants