move separate_multiplicative key outside sampling key in runcard#2128
Merged
Conversation
Member
This solution works for me.
But given we already have the option to be able to change between the two modes, we might as well keep it. It might be useful to test (and to compare with 4.0). |
andreab1997
approved these changes
Jul 17, 2024
Contributor
andreab1997
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for this!
this fixes vp-setupfit since there separate_multiplicative was not parsed from the sampling key and thus it was not found
18ffbc9 to
f0efd96
Compare
Member
Author
|
I don't think you can use the same name for user-input and for the result of a parse_ or produce_ function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes vp-setupfit since there
separate_multiplicativewas not parsed from thesamplingkey and thus it was not found. This was broken in #2107This also resolves #2106 by removing the sampling namespace all together, though since we never use it we may also want to drop the
separate_multiplicativekeyword all together.