Skip to content

move separate_multiplicative key outside sampling key in runcard#2128

Merged
RoyStegeman merged 5 commits into
masterfrom
fix_sep_mult_key
Jul 19, 2024
Merged

move separate_multiplicative key outside sampling key in runcard#2128
RoyStegeman merged 5 commits into
masterfrom
fix_sep_mult_key

Conversation

@RoyStegeman
Copy link
Copy Markdown
Member

This fixes vp-setupfit since there separate_multiplicative was not parsed from the sampling key and thus it was not found. This was broken in #2107

This also resolves #2106 by removing the sampling namespace all together, though since we never use it we may also want to drop the separate_multiplicative keyword all together.

@RoyStegeman RoyStegeman added the bug Something isn't working label Jul 17, 2024
@scarlehoff
Copy link
Copy Markdown
Member

This also resolves #2106 by removing the sampling namespace all together,

This solution works for me.

though since we never use it we may also want to drop the separate_multiplicative keyword all together.

But given we already have the option to be able to change between the two modes, we might as well keep it. It might be useful to test (and to compare with 4.0).

Copy link
Copy Markdown
Contributor

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this!

@RoyStegeman
Copy link
Copy Markdown
Member Author

I don't think you can use the same name for user-input and for the result of a parse_ or produce_ function

@RoyStegeman RoyStegeman merged commit 737382f into master Jul 19, 2024
@RoyStegeman RoyStegeman deleted the fix_sep_mult_key branch July 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add resample_negative_pseudodata to the sampling namespace

3 participants