Skip to content

Reimplement Atlas Z0 8 TeV lowmass#2205

Merged
scarlehoff merged 14 commits into
masterfrom
reimplement_ATLAS_Z0_8TEV_LOWMASS
Jan 22, 2025
Merged

Reimplement Atlas Z0 8 TeV lowmass#2205
scarlehoff merged 14 commits into
masterfrom
reimplement_ATLAS_Z0_8TEV_LOWMASS

Conversation

@comane
Copy link
Copy Markdown
Member

@comane comane commented Nov 9, 2024

Possible bugs were found in the old implementation:

  1. The overall multiplicative factor of the luminosity uncertainty given on hep-data (see https://www.hepdata.net/record/117854) is 1.8 %. In the old implementation 1.9 % was taken

-> I have incorporated this modification as it makes not a big difference

(this branch) https://vp.nnpdf.science/XpC1u8GqSyapV3e-ffvpwg==

(master) https://vp.nnpdf.science/7KddpIE6S9u2aBAfuTybkQ==

  1. In the old implementation Lumi uncertainty is assumed to be MULT UNCORR. I have noticed that setting the Lumi uncertainty to CORR the chi2 grows by an order of magnitude. I am not sure I understand this. Perhaps in this case Lumi is supposed to be UNCORR?

Comment thread nnpdf_data/nnpdf_data/commondata/ATLAS_Z0_8TEV_LOWMASS/filter.py Outdated
@Radonirinaunimi
Copy link
Copy Markdown
Member

Hi @comane, you need to run the regenerate-data bot to make the commondata test pass.

@scarlehoff scarlehoff mentioned this pull request Dec 6, 2024
5 tasks
@comane comane force-pushed the reimplement_ATLAS_Z0_8TEV_LOWMASS branch from 2bd9a64 to 69a33a2 Compare December 7, 2024 18:58
Comment thread nnpdf_data/nnpdf_data/commondata/ATLAS_Z0_8TEV_LOWMASS/filter.py
@comane comane requested a review from t7phy December 8, 2024 12:18
@t7phy
Copy link
Copy Markdown
Collaborator

t7phy commented Dec 15, 2024

@comane besides the minor comments, seems fine to me. Pls check with @enocera (if not already done) about the CORR/UNCORR business and then this can be merged.

@comane comane force-pushed the reimplement_ATLAS_Z0_8TEV_LOWMASS branch from a8c3d01 to 8803094 Compare January 15, 2025 14:02
@enocera
Copy link
Copy Markdown
Contributor

enocera commented Jan 21, 2025

Possible bugs were found in the old implementation:

1. The overall multiplicative factor of the luminosity uncertainty given on hep-data (see https://www.hepdata.net/record/117854) is 1.8 %. In the old implementation 1.9 % was taken

-> I have incorporated this modification as it makes not a big difference

(this branch) https://vp.nnpdf.science/XpC1u8GqSyapV3e-ffvpwg==

(master) https://vp.nnpdf.science/7KddpIE6S9u2aBAfuTybkQ==

Great. This is a tiny issue.

2. In the old implementation Lumi uncertainty is assumed to be MULT UNCORR. I have noticed that setting the Lumi uncertainty to CORR the chi2 grows by an order of magnitude. I am not sure I understand this. Perhaps in this case Lumi is supposed to be UNCORR?

This is a more relevant issue. It looks like that this is a genuine bug. The luminosity must be correlated. In this very specific case, furthermore, it must be correlated with all the other ATLAS 8 TeV data obtained from the same run. Specifically, it is the 2012 run with 20.2 fb^-1. This means that the luminosity uncertainty must be tagged with a string that must be the same across the following data sets:

  • ATLAS high-mass DY 2D 8 TeV [arXiv:1606.01736]
  • ATLAS W ±+jet 8 TeV [arXiv:1711.03296]
  • ATLAS Z pT 8 TeV (two data sets) [arXiv:1512.02192]
  • ATLAS ttbar l+jets 8 TeV (all absolute diff. distr.) [arxIv:1511.04716]
  • ATLAS single.inclusive jets 8 TeV [arXiv:1706.03192]
  • ATLAS prompt photon 8 TeV [arXiv:1605.03495]
  • ATLAS single top 8 TeV (all absolute distr.) [arXiv:1702.02859]

@t7phy
Copy link
Copy Markdown
Collaborator

t7phy commented Jan 21, 2025

In the ATLAS ttbar l+jets 8 TeV set, I had used MULT ATLASLUMI8. I guess the same could be used here.

@enocera
Copy link
Copy Markdown
Contributor

enocera commented Jan 21, 2025

You have freedom in choosing the string. The important thing is to use it consistently across data sets.

@scarlehoff
Copy link
Copy Markdown
Member

Actually, I think the string we have been using is ATLASLUMI12 so it should be changed also in the top data.

@comane comane force-pushed the reimplement_ATLAS_Z0_8TEV_LOWMASS branch from 8803094 to 8e1580c Compare January 22, 2025 17:40
@comane
Copy link
Copy Markdown
Member Author

comane commented Jan 22, 2025

Report for last commit:
https://vp.nnpdf.science/EK2J-BJyRV2_zKT2-Zeoyg==

@scarlehoff scarlehoff merged commit 4da53ad into master Jan 22, 2025
@scarlehoff scarlehoff deleted the reimplement_ATLAS_Z0_8TEV_LOWMASS branch January 22, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants