Modify the VP api so it can take its own objects.#2268
Merged
Conversation
scarlehoff
force-pushed
the
api_extended_feb25
branch
from
83945a9 to
aa07cc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the validphys api is limited to strings for PDFs. This small change allows to take either already loaded PDFs or other objects (such as the PDFs coming directly from n3fit).
Note: while
from __future__ import annotationswould allow usingUnion[str, PDF]in python 3.9, this in practice changes PDF to "PDF" (which was the old way) and this is not allowed/understood by reportengine. So for now the type annotation for the pdf name must be removed forparse_pdfto allow both strings and classes.