Skip to content

Modify the VP api so it can take its own objects. #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scarlehoff merged 2 commits into from
Feb 4, 2025
+8 −1
Merged

Modify the VP api so it can take its own objects. #2268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88bd426
allows the vp API to take PDF objects directly
scarlehoff Feb 3, 2025
aa07cc9
remove type annotation
scarlehoff Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion validphys2/src/validphys/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from reportengine.helputils import get_parser_type
from reportengine.namespaces import NSList
from validphys.core import (
PDF,
CutsPolicy,
DataGroupSpec,
DataSetInput,
Expand Down Expand Up @@ -147,10 +148,16 @@ def _check_pdf_usable(self, pdf_name: str):

@element_of("pdfs")
@_id_with_label
def parse_pdf(self, name: str, unpolarized_bc=None):
def parse_pdf(self, name, unpolarized_bc=None):
"""A PDF set installed in LHAPDF.
If an unpolarized boundary condition it defined, it will be registered as part of the PDF.

If ``name`` is already an instance of a vp PDF object, return it unchanged.
"""
# NB: for reportengine to check the inputs, name should have type: Union[str, PDF]
# to be changed when support for older versions of python is dropped
if isinstance(name, PDF):
return name
pdf = self._check_pdf_usable(name)
if unpolarized_bc is not None:
pdf.register_boundary(unpolarized_bc=unpolarized_bc)
Expand Down