Skip to content

Update to pandas version 1#692

Merged
Zaharid merged 2 commits into
masterfrom
pandas1
Apr 2, 2020
Merged

Update to pandas version 1#692
Zaharid merged 2 commits into
masterfrom
pandas1

Conversation

@Zaharid
Copy link
Copy Markdown
Contributor

@Zaharid Zaharid commented Mar 31, 2020

This contains the fix for the one failing test. There are likely many
more things that broke.

Closes #690.
Closes #697.

This contains the fix for the one failing test. There are likely many
more things that broke.
@Zaharid
Copy link
Copy Markdown
Contributor Author

Zaharid commented Mar 31, 2020

@RosalynLP @voisey Pandas loves to break the user interface in all sorts of weird ways (and sometimes even change semantics so that you get wrong result). I have fixed the instance that is failing in the tests, but there are other things like in particular the theory covariance stuff that may be broken now. Unfortunately we also don't have tests for those (and the corresponding PR was closed).

Could you please try to run some representative reports and see that they work?

@siranipour
Copy link
Copy Markdown
Contributor

Updating pandas scares me

@RosalynLP
Copy link
Copy Markdown
Contributor

image

@RosalynLP
Copy link
Copy Markdown
Contributor

@RosalynLP @voisey Pandas loves to break the user interface in all sorts of weird ways (and sometimes even change semantics so that you get wrong result). I have fixed the instance that is failing in the tests, but there are other things like in particular the theory covariance stuff that may be broken now. Unfortunately we also don't have tests for those (and the corresponding PR was closed).

Could you please try to run some representative reports and see that they work?

Will do

This should avoid travis timeouts and also help identifying failures.
@Zaharid
Copy link
Copy Markdown
Contributor Author

Zaharid commented Apr 1, 2020

It seems this still times out even if you download the resources first (and add a lot of noise to the logs). cc @wilsonmr .

@wilsonmr
Copy link
Copy Markdown
Contributor

wilsonmr commented Apr 1, 2020

ok so I added some more prints and ran conda build changing the test script to have

pytest ... -s

and it at least appears that it's getting stuck in test_plots.test_dataspecschi2

@wilsonmr
Copy link
Copy Markdown
Contributor

wilsonmr commented Apr 2, 2020

Is this ready? as per #697 I think there is a bit of urgency because at the moment it's a bit of a mess for people trying to transition to new reportengine

@RosalynLP
Copy link
Copy Markdown
Contributor

I am going to check some theorycov reports now to see if they still work

@RosalynLP
Copy link
Copy Markdown
Contributor

I am going to check some theorycov reports now to see if they still work

Still working by the looks of things!
image

@Zaharid
Copy link
Copy Markdown
Contributor Author

Zaharid commented Apr 2, 2020

Should we merge this then?

@scarrazza
Copy link
Copy Markdown
Member

Yes, please.

@wilsonmr
Copy link
Copy Markdown
Contributor

wilsonmr commented Apr 2, 2020

I wonder if afterwards we should send email suggesting people update environments/create new ones?

Seeing as nothing appears to be failing seems ok to merge

@Zaharid
Copy link
Copy Markdown
Contributor Author

Zaharid commented Apr 2, 2020

I wonder if afterwards we should send email suggesting people update environments/create new ones?

Shouldn't environments work fine automatically? When you update nnpdf, both pandas and reportengine should be updated as well. And if you don't update everything that used to work should keep working...

@Zaharid Zaharid merged commit f3bb370 into master Apr 2, 2020
@scarrazza scarrazza deleted the pandas1 branch April 22, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need pandas 1.x.x if using new reportengine conda pkgs for reportengine

5 participants