[WIP]: Python commondata parser#769
Conversation
…npdf into python-commondata-parser
|
So far I've implemented most of this, i.e.
Still to do:
|
d774074 to
3a08e67
Compare
dba0f95 to
1cc8329
Compare
|
There is a problem at the moment that the commondata files start indexing from 1, while |
Although I like the idea of indexing from 0 I worry that if someone were to identify point 224 for example, and then wanted to find that entry in the commondata file for whatever reason we'd want those two to match up. I'd think shifting the cuts would be best in this scenario. |
|
Yeah I worry both will probably be a bit of a mess, but your method less so. I'll do that in the next commit! |
|
Thanks @siranipour |
61f737f to
2325c4c
Compare
| Note if the first data point passes cuts, the first entry | ||
| of ``cuts`` should be ``0``. |
There was a problem hiding this comment.
This is rather unclear. It reads to me like it should be a list starting with zero.
There was a problem hiding this comment.
That is what we mean right? If datapoint 1 passed cuts then cuts = [0, ...
We must do this as cuts indexing starts at 0 while commondata indexing starts at 1.
2325c4c to
11c4b5d
Compare
|
What else is left for this PR? |
Addresses the first part of #379. In a similar vein to #404 we want to load in the commondata from file and parse it, converting to central values, systematics etc. This is to be done using pandas.