Skip to content

Automatic scale variations#75

Merged
andreab1997 merged 204 commits into
mainfrom
auto_sv
May 23, 2023
Merged

Automatic scale variations#75
andreab1997 merged 204 commits into
mainfrom
auto_sv

Conversation

@andreab1997
Copy link
Copy Markdown
Contributor

@andreab1997 andreab1997 commented Jan 25, 2023

We want a new module called scale_variations that should be able to generate automatically renormalization and factorization scale variations starting from a pre-existing grid. It should also be able to generate a new grid filling the scale variations orders. The roadmap of this PR should be approximately the following

  • Be sure that pineappl_py is able to extract a subgrid, rescale it and construct a new grid (Note that for factorization scale variations we will also need convolutions)
  • Implement renormalization sv (easier)
  • Implement a cli (maybe taking advantage of the theory command) that can upgrade all the necessary grids for a dataset
  • Implement a module to include k_factors in a grid

@felixhekhorn @cschwan @alecandido This is just a draft, suggestions are welcomed :)

@andreab1997 andreab1997 changed the title Automatics scale variations Automatic scale variations Jan 25, 2023
@felixhekhorn felixhekhorn marked this pull request as draft January 27, 2023 09:54
@felixhekhorn felixhekhorn added the enhancement New feature or request label Jan 27, 2023
Copy link
Copy Markdown
Collaborator

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly suggestions about simplifying names, and clarifying the meaning. Nothing substantial on the task itself (but readability counts!)

Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
@andreab1997
Copy link
Copy Markdown
Contributor Author

Mainly suggestions about simplifying names, and clarifying the meaning. Nothing substantial on the task itself (but readability counts!)

Yes I know :) This is really only a draft. I just want to write a proof of concept example as soon as possible and I will improve docs and readability later. The main point is that I want to know if doing this is possible with what we already have or not. Anyway thanks for the comments :)

Not strictly related to this comment but I take the opportunity to tag @cschwan which may want to have a look.

@alecandido
Copy link
Copy Markdown
Collaborator

Yes I know :) This is really only a draft. I just want to write a proof of concept example as soon as possible and I will improve docs and readability later. The main point is that I want to know if doing this is possible with what we already have or not. Anyway thanks for the comments :)

I could see that it was a draft (apart from the draft mode, there were some missing implementations), but you wrote:

@felixhekhorn @cschwan @alecandido This is just a draft, suggestions are welcomed :)

so I acted consequently :D

@alecandido
Copy link
Copy Markdown
Collaborator

@andreab1997 whenever you actually need another review, either remove draft mode or tag me again :)

Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/check.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
Comment thread src/pineko/scale_variations.py Outdated
@andreab1997
Copy link
Copy Markdown
Contributor Author

andreab1997 commented May 23, 2023

Given that this PR is becoming very big and given that the tests are passing I would say that this is a good moment to merge it. I know that @alecandido, together with @cschwan, is making an effort to make the code here simpler but since we are all very busy I believe we can merge this as it is and we will open another PR once the necessary improvements in pineappl have been made. Do you agree?

@andreab1997 andreab1997 requested a review from alecandido May 23, 2023 14:22
@andreab1997 andreab1997 dismissed alecandido’s stale review May 23, 2023 14:23

Changes were addressed

@andreab1997 andreab1997 merged commit a78003a into main May 23, 2023
@andreab1997 andreab1997 deleted the auto_sv branch May 23, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants