Skip to content

Eko v0.13.0 compatibility#88

Closed
giacomomagni wants to merge 6 commits into
mainfrom
eko_compatibility_master
Closed

Eko v0.13.0 compatibility#88
giacomomagni wants to merge 6 commits into
mainfrom
eko_compatibility_master

Conversation

@giacomomagni
Copy link
Copy Markdown
Contributor

@giacomomagni giacomomagni commented Apr 19, 2023

This PR is for eko compatibility with ^0.13 0.13.0

@andreab1997 andreab1997 changed the title Eko comatibility with master ie ^0.13 Eko compatibility with master ie ^0.13 Apr 19, 2023
Comment thread src/pineko/evolve.py Outdated
@felixhekhorn felixhekhorn added the refactor Refactor code label May 12, 2023
@felixhekhorn felixhekhorn changed the title Eko compatibility with master ie ^0.13 Eko v0.13.0 compatibility May 12, 2023
@alecandido
Copy link
Copy Markdown
Collaborator

Since we have been bad[*] at stability with EKO, we decided to start from the very basics, and to limit the public API to runcards and the solve function.

The result is that Pineko depends on EKO internals, so there might be (small) breaking changes even in patch releases.
If we declare immediately public all what is needed for Pineko, the risk is to never achieve stability, since we'd limit a lot ourselves, just before a round of major refactoring. However, since we know Pineko, we care about breaking little, and we will try to prioritize the publication of the API required. While, in Pineko, we will try to limit EKO API usage as much as possible.

[*]: because of fast development, bugs fixing, and lack of resources, not because we don't care

@andreab1997
Copy link
Copy Markdown
Contributor

What is missing here is mainly fixing the tests and the benchmarks. However, since fixing the benchmarks requires changing the benchmark files and since the files can be correct either for this PR or for #75, not for both, I would like first to merge #75 (in such a way tests and benchmarks there work) and only then rebase this on main and break the benchmarks again.
So, just to remember, I am switching this to draft. @felixhekhorn @alecandido @giacomomagni

@andreab1997 andreab1997 marked this pull request as draft May 16, 2023 10:17
@alecandido
Copy link
Copy Markdown
Collaborator

alecandido commented May 16, 2023

Just to write it here for the benefit of everyone: I proposed to actually fix the benchmarks for this PR, since it has a greater priority and it is partially blocking some other tasks (or the completion of this might simplify something else). While #75 is more standalone.

@andreab1997 andreab1997 mentioned this pull request May 22, 2023
1 task
@andreab1997 andreab1997 deleted the eko_compatibility_master branch May 22, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants