Added more attributes to dataset model#41
Merged
einfachMel merged 19 commits intomainfrom Dec 20, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 91.02% 90.98% -0.04%
==========================================
Files 79 88 +9
Lines 1170 1365 +195
==========================================
+ Hits 1065 1242 +177
- Misses 105 123 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
# Conflicts: # ensysmod/crud/energy_conversion.py # ensysmod/crud/energy_transmission.py
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # ensysmod/schemas/base_ref_component_region.py
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # ensysmod/api/api.py # tests/utils/data_generator/__init__.py # tests/utils/data_generator/energy_conversions.py # tests/utils/data_generator/energy_transmissions.py
This comment has been minimized.
This comment has been minimized.
Contributor
einfachMel
approved these changes
Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40
This PR ...
improves the dataset model and adds more attributes.
All changes are needed to model the FINE example correctly.
Checklist
Checklist for Contributors
Unit tests are needed for new features or to reproduce the bug solved by this PR.
Checklist for Reviewers