Skip to content

Added more attributes to dataset#82

Merged
einfachMel merged 2 commits intomainfrom
feature/improve-dataset-model
Jan 23, 2022
Merged

Added more attributes to dataset#82
einfachMel merged 2 commits intomainfrom
feature/improve-dataset-model

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Jan 23, 2022

Fixes #79

This PR ...

adds more attributes to dataset. See linked issue.

Also adds validation for length of time series data.


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #82 (1093db2) into main (3d7d244) will increase coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   83.03%   83.08%   +0.05%     
==========================================
  Files          93       93              
  Lines        1762     1774      +12     
==========================================
+ Hits         1463     1474      +11     
- Misses        299      300       +1     
Flag Coverage Δ
pytest 83.08% <91.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/crud/base_depends_timeseries.py 60.00% <75.00%> (+1.30%) ⬆️
ensysmod/model/dataset.py 100.00% <100.00%> (ø)
ensysmod/schemas/dataset.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7d244...1093db2. Read the comment docs.

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

  1 files  ±0    1 suites  ±0   49s ⏱️ -8s
63 tests ±0  63 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 1093db2. ± Comparison against base commit 3d7d244.

@github-actions github-actions bot temporarily deployed to PR-82-Preview January 23, 2022 13:13 Destroyed
@V3lop5 V3lop5 requested a review from einfachMel January 23, 2022 13:44
@einfachMel einfachMel added the enhancement New feature or request label Jan 23, 2022
@einfachMel einfachMel merged commit 9d96989 into main Jan 23, 2022
@einfachMel einfachMel deleted the feature/improve-dataset-model branch January 23, 2022 20:12
V3lop5 added a commit that referenced this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Dataset model

3 participants