Skip to content

Generate FINE energy system model from database#83

Merged
V3lop5 merged 12 commits intomainfrom
feature/fine-esm
Feb 3, 2022
Merged

Generate FINE energy system model from database#83
V3lop5 merged 12 commits intomainfrom
feature/fine-esm

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Jan 23, 2022

Fixes #33

This PR ...

generates FINE energy system model from data in database.

Open TODOs


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

Added components to dataset
Changed DECIMAL types to float
Added capacity_variable true
Fixed some imports
@github-actions

This comment has been minimized.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #83 (254b054) into main (9f5ee12) will decrease coverage by 4.33%.
The diff coverage is 40.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   83.79%   79.46%   -4.34%     
==========================================
  Files          97       98       +1     
  Lines        1864     2031     +167     
==========================================
+ Hits         1562     1614      +52     
- Misses        302      417     +115     
Flag Coverage Δ
pytest 79.46% <40.79%> (-4.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/core/fine_esm.py 16.51% <16.51%> (ø)
ensysmod/api/endpoints/energy_models.py 59.18% <30.00%> (-12.70%) ⬇️
ensysmod/crud/base_depends_timeseries.py 58.18% <42.85%> (-1.82%) ⬇️
ensysmod/model/dataset.py 76.19% <69.69%> (-23.81%) ⬇️
ensysmod/crud/energy_sink.py 100.00% <100.00%> (ø)
ensysmod/crud/energy_source.py 100.00% <100.00%> (ø)
ensysmod/model/energy_component.py 100.00% <100.00%> (ø)
ensysmod/model/energy_conversion.py 100.00% <100.00%> (ø)
ensysmod/model/energy_conversion_factor.py 100.00% <100.00%> (ø)
ensysmod/model/energy_model.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5ee12...254b054. Read the comment docs.

@github-actions github-actions bot temporarily deployed to PR-83-Preview January 23, 2022 13:21 Destroyed
@github-actions github-actions bot temporarily deployed to PR-83-Preview January 29, 2022 12:53 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-83-Preview January 29, 2022 13:04 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-83-Preview February 2, 2022 08:19 Destroyed
Removed capacity_variable from biogas import
Added costs to GuD Methan
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2022

Unit Test Results

  1 files  ±0    1 suites  ±0   44s ⏱️ -3s
63 tests ±0  63 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 254b054. ± Comparison against base commit 9f5ee12.

@github-actions github-actions bot temporarily deployed to PR-83-Preview February 3, 2022 09:44 Destroyed
@V3lop5 V3lop5 marked this pull request as ready for review February 3, 2022 09:50
@V3lop5 V3lop5 requested a review from einfachMel February 3, 2022 09:50
@V3lop5 V3lop5 merged commit 3636c53 into main Feb 3, 2022
@V3lop5 V3lop5 deleted the feature/fine-esm branch February 3, 2022 09:50
@V3lop5 V3lop5 added the enhancement New feature or request label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate FINE model from energy_model

2 participants