Korean: add missing MULTIUSER_INSTALLMODEPAGE strings#32
Closed
Debaq wants to merge 1 commit into
Closed
Conversation
Add the five MULTIUSER_INSTALLMODEPAGE LangString translations that were missing from the Korean language file: - MULTIUSER_TEXT_INSTALLMODE_TITLE - MULTIUSER_TEXT_INSTALLMODE_SUBTITLE - MULTIUSER_INNERTEXT_INSTALLMODE_TOP - MULTIUSER_INNERTEXT_INSTALLMODE_ALLUSERS - MULTIUSER_INNERTEXT_INSTALLMODE_CURRENTUSER Without these, Korean installers built with MultiUser.nsh fell back to English on the install-mode selection page.
Open
2 tasks
Member
|
Thank you, will be included in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the five
MULTIUSER_INSTALLMODEPAGELangStringtranslations that were missing fromContrib/Language files/Korean.nsh:MULTIUSER_TEXT_INSTALLMODE_TITLEMULTIUSER_TEXT_INSTALLMODE_SUBTITLEMULTIUSER_INNERTEXT_INSTALLMODE_TOPMULTIUSER_INNERTEXT_INSTALLMODE_ALLUSERSMULTIUSER_INNERTEXT_INSTALLMODE_CURRENTUSERWithout these, Korean installers that include
MultiUser.nshand use the install-mode page fall back to English on that page only, which looks broken in an otherwise fully-translated installer.The block follows the same
!ifdef MULTIUSER_INSTALLMODEPAGEstructure already used byTradChinese.nsh,Vietnamese.nsh,Ukrainian.nsh, and others.Context
I originally fixed this downstream in Tauri (tauri-apps/tauri#15294, where
tauri-bundlerships its own copy of the NSIS language files), and a Tauri maintainer rightly suggested upstreaming the fix here so that every project using NSIS benefits, not just Tauri apps.Thanks
I just want to say a sincere thank you to the NSIS project and everyone who maintains it. NSIS is what makes my Windows apps actually start for users — without it I'd have no good way to ship native installers for the small open-source tools I build. It's been quietly powering Windows software for decades, and projects like mine wouldn't reach Windows users at all without it. Truly grateful. 🙏
Test plan
${LangFileString}form already used in this language file and in other languages' MULTIUSER blocks).MULTIUSER_INSTALLMODEPAGEis defined, matching the convention in other language files.