fix(bundler): add missing MULTIUSER LangString translations for Korean NSIS#15294
fix(bundler): add missing MULTIUSER LangString translations for Korean NSIS#15294Debaq wants to merge 2 commits into
Conversation
…n NSIS Adds Korean translations for the 5 MULTIUSER strings used when installMode is set to 'both', avoiding fallback to English during build: - MULTIUSER_TEXT_INSTALLMODE_TITLE - MULTIUSER_TEXT_INSTALLMODE_SUBTITLE - MULTIUSER_INNERTEXT_INSTALLMODE_TOP - MULTIUSER_INNERTEXT_INSTALLMODE_ALLUSERS - MULTIUSER_INNERTEXT_INSTALLMODE_CURRENTUSER
- Rust: corregir 'unused variable home' (micromamba.rs) y 'unused variable window' (lib.rs). - Vite: split chunks (radix, charts, konva, pdf, tauri) — main bundle 1.6MB → 870KB. Sube chunkSizeWarningLimit a 1000. - NSIS: customLanguageFiles para Korean con 5 strings MULTIUSER faltantes. Override local mientras se mergea PR upstream tauri-apps/tauri#15294; eliminar src-tauri/nsis/Korean.nsh + entrada customLanguageFiles cuando esté disponible.
Package Changes Through 24e8b57There are 11 changes which include tauri with minor, @tauri-apps/api with minor, tauri-build with minor, tauri-macos-sign with patch, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Hi, thanks for contributing I don't mind adding this just to tauri, but does it make sense to upstream to https://github.com/NSIS-Dev/nsis/blob/affd49994d092bc0a7ba505d87b41de7aecfb738/Contrib/Language%20files/Korean.nsh instead so this benefits everyone using NSIS? |
|
Good point, hadn't thought of that — you're right that upstreaming benefits the whole NSIS ecosystem. Happy to open a PR against NSIS-Dev/nsis with the same 5 strings. My only concern is that it could take a while to land and ship in a tagged NSIS release, plus Tauri would then need to bump its embedded NSIS version. So I'd suggest keeping this PR open as a short-term fix in the meantime, and once the upstream change is released and pulled in here, the override can just be removed. Let me know if that works for you and I'll open the upstream PR today. Nico.- |
|
Quick update: opened the upstream PR — NSIS-Dev/nsis#32. Same five Once that lands and gets pulled into a tauri-bundler NSIS sync, the override here can simply be deleted. Off-topic, but: thank you to the whole Tauri team for the project. Loving working with it. Nico! |
|
You could perhaps put these new strings inside |
3 participants
Summary
Adds the 5 missing
MULTIUSER_*LangString translations toKorean.nshso Korean installers built with `installMode: "both"` no longer fall back to English for the install-mode dialog.Currently, building a Tauri app with NSIS bundle that lists `Korean` in `bundle.windows.nsis.languages` and uses `installMode: "both"` produces these warnings:
```
warning: !warning: LangString "MULTIUSER_TEXT_INSTALLMODE_TITLE" for language Korean is missing, using fallback from "...\English.nsh"
warning: !warning: LangString "MULTIUSER_TEXT_INSTALLMODE_SUBTITLE" for language Korean is missing, ...
warning: !warning: LangString "MULTIUSER_INNERTEXT_INSTALLMODE_TOP" for language Korean is missing, ...
warning: !warning: LangString "MULTIUSER_INNERTEXT_INSTALLMODE_ALLUSERS" for language Korean is missing, ...
warning: !warning: LangString "MULTIUSER_INNERTEXT_INSTALLMODE_CURRENTUSER" for language Korean is missing, ...
```
This PR adds Korean translations for those 5 strings.
Notes for reviewers
The translations were derived from the English equivalents. Native Korean speaker review would be appreciated to confirm naturalness — happy to amend.
Test plan