ci: Remove thirdparty aiohttp file from ray#1469
Merged
Conversation
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| # Install Curator | ||
| RUN uv sync --link-mode copy --locked --extra all --all-groups --no-cache | ||
| RUN uv sync --link-mode copy --locked --extra all --all-groups --no-cache && \ | ||
| find /opt/venv -type d -path "*ray/_private/runtime_env/agent/thirdparty_files/aiohttp*" -exec rm -rf {} + |
Contributor
There was a problem hiding this comment.
The find command could be more robust. The current pattern matches any aiohttp* directory anywhere in the path, which could unintentionally delete legitimate dependencies if the directory structure changes. Consider making the deletion more explicit and fail-safe:
Suggested change
| find /opt/venv -type d -path "*ray/_private/runtime_env/agent/thirdparty_files/aiohttp*" -exec rm -rf {} + | |
| ray_aiohttp_dir="/opt/venv/lib/python*/site-packages/ray/_private/runtime_env/agent/thirdparty_files/aiohttp" && \ | |
| [ -d "$ray_aiohttp_dir"* ] && rm -rf "$ray_aiohttp_dir"* || true |
This approach:
- Uses a more precise path pattern
- Checks directory exists before deletion
- Prevents build failure if path doesn't exist
- Makes the intent clearer
sarahyurick
approved these changes
Feb 6, 2026
thomasdhc
added a commit
that referenced
this pull request
Feb 9, 2026
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Usage
# Add snippet demonstrating usageChecklist