Skip to content

ci: Remove thirdparty aiohttp file from ray #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasdhc merged 2 commits into from
Feb 9, 2026
Merged

ci: Remove thirdparty aiohttp file from ray #1469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eff6f4
Scrub thirdparty aiohttp file from ray
thomasdhc Feb 6, 2026
1d3290c
Merge branch 'main' into donghyukc/scrub_ray_aiohttp
thomasdhc Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ COPY pyproject.toml uv.lock /opt/Curator/
COPY nemo_curator/__init__.py nemo_curator/package_info.py /opt/Curator/nemo_curator/

# Install Curator
Comment on lines 71 to 73
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overbroad recursive deletion

find /opt/venv ... -exec rm -rf {} + will delete every matching directory under the virtualenv, including any aiohttp* path segments that happen to appear outside Ray’s vendored thirdparty_files tree (e.g., if the path layout changes or another package path happens to match). This is a destructive step during image build and can silently remove real installed dependencies. Consider constraining the deletion to the exact expected directory (or verifying it exists before removing), and avoid the aiohttp* wildcard unless you really need it.

RUN uv sync --link-mode copy --locked --extra all --all-groups --no-cache
RUN uv sync --link-mode copy --locked --extra all --all-groups --no-cache && \
find /opt/venv -type d -path "*ray/_private/runtime_env/agent/thirdparty_files/aiohttp*" -exec rm -rf {} +
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The find command could be more robust. The current pattern matches any aiohttp* directory anywhere in the path, which could unintentionally delete legitimate dependencies if the directory structure changes. Consider making the deletion more explicit and fail-safe:

Suggested change
find /opt/venv -type d -path "*ray/_private/runtime_env/agent/thirdparty_files/aiohttp*" -exec rm -rf {} +
ray_aiohttp_dir="/opt/venv/lib/python*/site-packages/ray/_private/runtime_env/agent/thirdparty_files/aiohttp" && \
[ -d "$ray_aiohttp_dir"* ] && rm -rf "$ray_aiohttp_dir"* || true

This approach:

  • Uses a more precise path pattern
  • Checks directory exists before deletion
  • Prevents build failure if path doesn't exist
  • Makes the intent clearer


COPY . /opt/Curator

Expand Down
Loading