Drop PyTorch 2.1 version check from fabric strategies#10079
Merged
akoumpa merged 5 commits intoNVIDIA-NeMo:mainfrom Aug 9, 2024
Merged
Drop PyTorch 2.1 version check from fabric strategies#10079akoumpa merged 5 commits intoNVIDIA-NeMo:mainfrom
akoumpa merged 5 commits intoNVIDIA-NeMo:mainfrom
Conversation
Contributor
Author
|
@marcromeyn @jstjohn for vis |
Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com>
Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com>
farhadrgh
force-pushed
the
farhadr/fabric
branch
from
0748a11 to
41ab06c
Compare
Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com>
…to farhadr/fabric
hemildesai
approved these changes
Aug 8, 2024
8 tasks
This was referenced Aug 8, 2024
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
) * rm torch version check Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> * bump min torch version Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> * rm version Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> --------- Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> Co-authored-by: Marc Romeyn <mromeijn@nvidia.com> Signed-off-by: adityavavre <aditya.vavre@gmail.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* rm torch version check Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> * bump min torch version Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> * rm version Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> --------- Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
) * rm torch version check Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> * bump min torch version Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> * rm version Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> --------- Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> Co-authored-by: Marc Romeyn <mromeijn@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
) * rm torch version check Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> * bump min torch version Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> * rm version Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> --------- Signed-off-by: Farhad Ramezanghorbani <farhad.ghorbani@gmail.com> Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Lightning has Dropped PyTorch 2.0 from the test matrix and
TORCH_GREATER_EQUAL_2_1no longer exists. I bumped the version requirement instead of import/check inNeMo/nemo/lightning/fabric/strategies.pyCollection: [Note which collection this PR will affect]
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information