Merged
Conversation
Collaborator
Author
|
/build-ci |
1 similar comment
Collaborator
Author
|
/build-ci |
jstjohn
reviewed
Aug 8, 2024
requirements-dev.txt
Outdated
Collaborator
There was a problem hiding this comment.
Can you add a comment to drop this requirement once the NeMo update merges and we fix our issues with TOT? NVIDIA-NeMo/NeMo#10079
Collaborator
There was a problem hiding this comment.
also shouldn't this be in our core requirements rather than just dev? Seems like test etc should get this.
Collaborator
Author
There was a problem hiding this comment.
sure, moved it to bionemo-core/requirements.txt
jstjohn
approved these changes
Aug 8, 2024
Closed
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
force-pushed
the
pstjohn/v2-main/pin-pytorch-lightning
branch
from
5f8d748 to
86e6546
Compare
gwarmstrong
approved these changes
Aug 8, 2024
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.