[TTS][ja-JP] add g2p, dict, tokenizer. by BuyuanCui · Pull Request #9538 · NVIDIA-NeMo/NeMo

BuyuanCui · 2024-06-25T19:12:24Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

nemo/collections/tts/g2p/models/ja_jp_g2p.py

nemo/collections/common/tokenizers/text_to_speech/tokenizer_utils.py

BuyuanCui · 2024-07-12T01:18:31Z

The files that had updates are:
nemo/collections/common/tokenizers/text_to_speech/ipa_lexicon.py
nemo/collections/common/tokenizers/text_to_speech/tokenizer_utils.py
nemo/collections/common/tokenizers/text_to_speech/tts_tokenizers.py
nemo/collections/tts/g2p/models/i18n_ipa.py
tests/collections/common/tokenizers/text_to_speech/test_tokenizer_utils.py
tests/collections/common/tokenizers/text_to_speech/test_tts_tokenizers.py
nemo/collections/tts/g2p/models/ja_jp_g2p.py
scripts/tts_dataset_files/ja_JP/ja_JP_wordtoipa.txt

tests/collections/common/tokenizers/text_to_speech/test_tts_tokenizers.py

This reverts commit 53d7a91.

* Revert "Jpg2p jun18 (#9538)" This reverts commit 53d7a91. * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com>

* Revert "Jpg2p jun18 (#9538)" This reverts commit 53d7a91. * Need first jobs to succeed * Make failing jobs optional * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com>

This reverts commit 53d7a91.

* adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Revert "Jpg2p jun18 (#9538)" This reverts commit 53d7a91. * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Revert "Jpg2p jun18 (#9538)" This reverts commit 53d7a91. * Need first jobs to succeed * Make failing jobs optional * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* Revert "Jpg2p jun18 (NVIDIA-NeMo#9538)" This reverts commit 53d7a91. * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* Revert "Jpg2p jun18 (NVIDIA-NeMo#9538)" This reverts commit 53d7a91. * Need first jobs to succeed * Make failing jobs optional * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Vivian Chen <xuanzic@example.com>

* Revert "Jpg2p jun18 (NVIDIA-NeMo#9538)" This reverts commit 53d7a91. * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com> Signed-off-by: Vivian Chen <xuanzic@example.com>

* Revert "Jpg2p jun18 (NVIDIA-NeMo#9538)" This reverts commit 53d7a91. * Need first jobs to succeed * Make failing jobs optional * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com> Signed-off-by: Vivian Chen <xuanzic@example.com>

* adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: kchike <kohei.chike@jp.ricoh.com>

* adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

* Revert "Jpg2p jun18 (#9538)" This reverts commit 53d7a91. * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com>

* Revert "Jpg2p jun18 (#9538)" This reverts commit 53d7a91. * Need first jobs to succeed * Make failing jobs optional * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com>

* adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Revert "Jpg2p jun18 (NVIDIA-NeMo#9538)" This reverts commit 53d7a91. * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Revert "Jpg2p jun18 (NVIDIA-NeMo#9538)" This reverts commit 53d7a91. * Need first jobs to succeed * Make failing jobs optional * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

* Revert "Jpg2p jun18 (NVIDIA-NeMo#9538)" This reverts commit 53d7a91. * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com>

* Revert "Jpg2p jun18 (NVIDIA-NeMo#9538)" This reverts commit 53d7a91. * Need first jobs to succeed * Make failing jobs optional * Apply isort and black reformatting Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> --------- Signed-off-by: pablo-garay <pablo-garay@users.noreply.github.com> Co-authored-by: pablo-garay <pablo-garay@users.noreply.github.com>

github-actions bot added TTS common labels Jun 25, 2024

BuyuanCui closed this Jun 25, 2024

BuyuanCui reopened this Jun 25, 2024

BuyuanCui marked this pull request as draft June 25, 2024 19:13

github-advanced-security bot found potential problems Jul 3, 2024

View reviewed changes

nemo/collections/tts/g2p/models/ja_jp_g2p.py Fixed Show fixed Hide fixed

nemo/collections/common/tokenizers/text_to_speech/tokenizer_utils.py Fixed Show fixed Hide fixed

nemo/collections/common/tokenizers/text_to_speech/tokenizer_utils.py Fixed Show fixed Hide fixed

BuyuanCui marked this pull request as ready for review July 12, 2024 01:16

XuesongYang added the Run CICD label Jul 12, 2024

github-advanced-security bot found potential problems Jul 12, 2024

View reviewed changes

tests/collections/common/tokenizers/text_to_speech/test_tts_tokenizers.py Fixed Show fixed Hide fixed

BuyuanCui force-pushed the jpg2p_jun18 branch from 5e922eb to 20431c8 Compare July 12, 2024 20:02

github-actions bot added core Changes to NeMo Core ASR NLP CI Multi Modal audio labels Jul 12, 2024

BuyuanCui closed this Jul 12, 2024

BuyuanCui force-pushed the jpg2p_jun18 branch from bcc9a1c to 599b60f Compare July 12, 2024 22:32

BuyuanCui reopened this Jul 12, 2024

github-actions bot removed core Changes to NeMo Core ASR NLP CI Multi Modal labels Jul 12, 2024

Merge branch 'main' into jpg2p_jun18

5102ec4

XuesongYang approved these changes Jul 24, 2024

View reviewed changes

XuesongYang added Run CICD and removed Run CICD labels Jul 24, 2024

XuesongYang merged commit 53d7a91 into NVIDIA-NeMo:main Jul 24, 2024

XuesongYang changed the title ~~Jpg2p jun18~~ [TTS][ja-JP] add g2p, dict, tokenizer. Jul 24, 2024

pablo-garay added a commit that referenced this pull request Jul 24, 2024

Revert "Jpg2p jun18 (#9538)"

6362691

This reverts commit 53d7a91.

XuesongYang added a commit that referenced this pull request Jul 25, 2024

Revert "Jpg2p jun18 (#9538)"

86e57dc

This reverts commit 53d7a91.

XuesongYang mentioned this pull request Jul 26, 2024

[TTS][ja-JP] g2p and tokenizer. #9879

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[TTS][ja-JP] add g2p, dict, tokenizer.#9538

[TTS][ja-JP] add g2p, dict, tokenizer.#9538
XuesongYang merged 49 commits intoNVIDIA-NeMo:mainfrom
BuyuanCui:jpg2p_jun18

BuyuanCui commented Jun 25, 2024 •

edited by XuesongYang

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BuyuanCui commented Jul 12, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

BuyuanCui commented Jun 25, 2024 • edited by XuesongYang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BuyuanCui commented Jul 12, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BuyuanCui commented Jun 25, 2024 •

edited by XuesongYang

Loading