[TTS][ja-JP] g2p and tokenizer. by XuesongYang · Pull Request #9879 · NVIDIA-NeMo/NeMo

XuesongYang · 2024-07-25T00:44:18Z

previously, #9538 was merged, but #9874 recently reverted it from main due to the blocks of building container. Diving into root causes, realized that it was mostly because of adding cutlet in requirements/requirements_tts.txt that blocks the container build. When fixing it, I also found the unit test did not capture the case when janome word segmenter is applied (this should be used by default).

Submit this PR again after fixing CICD failed tasks and bugfixes of unit tests.

adding japanese text preprocessing
japanese phoneme tokenizer
japanese tests
japanese g2p model
japanese word to ipa dictionary
add requirements

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

XuesongYang · 2024-07-25T00:45:58Z

add @BuyuanCui for vis.

* japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com>

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

* * adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: add prefix for ascii letters and fix unit test. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: remove tone_list. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> * fix: unit test Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * fix: wrong format Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> Co-authored-by: Alex Cui <alexcui1994@gmail.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: XuesongYang <XuesongYang@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* * adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: add prefix for ascii letters and fix unit test. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: remove tone_list. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> * fix: unit test Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * fix: wrong format Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> Co-authored-by: Alex Cui <alexcui1994@gmail.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: XuesongYang <XuesongYang@users.noreply.github.com> Signed-off-by: Vivian Chen <xuanzic@example.com>

* * adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: add prefix for ascii letters and fix unit test. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: remove tone_list. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> * fix: unit test Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * fix: wrong format Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> Co-authored-by: Alex Cui <alexcui1994@gmail.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: XuesongYang <XuesongYang@users.noreply.github.com>

* * adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: add prefix for ascii letters and fix unit test. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: remove tone_list. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> * fix: unit test Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * fix: wrong format Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> Co-authored-by: Alex Cui <alexcui1994@gmail.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: XuesongYang <XuesongYang@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* * adding japanese text preprocessing * japanese phoneme tokenizer * japanese tests * japanese g2p model * japanese word to ipa dictionary * add requirements Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: add prefix for ascii letters and fix unit test. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * bugfix: remove tone_list. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> * fix: unit test Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * fix: wrong format Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com> Co-authored-by: Alex Cui <alexcui1994@gmail.com> Co-authored-by: BuyuanCui <BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: XuesongYang <XuesongYang@users.noreply.github.com>

github-actions bot added TTS common labels Jul 25, 2024

XuesongYang added the Run CICD label Jul 25, 2024

XuesongYang force-pushed the jpg2p_jun18 branch from 4de3d70 to ce19331 Compare July 25, 2024 03:58

XuesongYang added Run CICD and removed Run CICD labels Jul 25, 2024

XuesongYang force-pushed the jpg2p_jun18 branch from ce19331 to d521fb8 Compare July 25, 2024 04:38

XuesongYang added Run CICD and removed Run CICD labels Jul 25, 2024

XuesongYang force-pushed the jpg2p_jun18 branch from 4116312 to 0fb997d Compare July 25, 2024 17:16

XuesongYang added Run CICD and removed Run CICD labels Jul 25, 2024

BuyuanCui and others added 5 commits July 26, 2024 02:41

bugfix: add prefix for ascii letters and fix unit test.

7632ddd

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

bugfix: remove tone_list.

e9a8ec0

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Apply isort and black reformatting

b82334c

Signed-off-by: XuesongYang <XuesongYang@users.noreply.github.com>

fix: unit test

0342ecc

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

XuesongYang force-pushed the jpg2p_jun18 branch from cfa93df to 0342ecc Compare July 26, 2024 09:42

fix: wrong format

721ad1d

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

XuesongYang added Run CICD and removed Run CICD labels Jul 26, 2024

XuesongYang requested review from blisc, mgrafu, pablo-garay, redoctopus and rlangman July 26, 2024 17:33

redoctopus approved these changes Jul 26, 2024

View reviewed changes

XuesongYang merged commit 491b577 into main Jul 26, 2024

XuesongYang deleted the jpg2p_jun18 branch July 26, 2024 20:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TTS][ja-JP] g2p and tokenizer.#9879

[TTS][ja-JP] g2p and tokenizer.#9879
XuesongYang merged 6 commits intomainfrom
jpg2p_jun18

XuesongYang commented Jul 25, 2024 •

edited

Loading

Uh oh!

XuesongYang commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

XuesongYang commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

XuesongYang commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

XuesongYang commented Jul 25, 2024 •

edited

Loading