Skip to content

ci: Fix unit test summary#128

Merged
chtruong814 merged 5 commits intomainfrom
chtruong/unit-test-summary
Apr 4, 2025
Merged

ci: Fix unit test summary#128
chtruong814 merged 5 commits intomainfrom
chtruong/unit-test-summary

Conversation

@chtruong814
Copy link
Copy Markdown
Contributor

@chtruong814 chtruong814 commented Apr 3, 2025

What does this PR do ?

Fix unit test summary in GHA

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@github-actions github-actions Bot added the CI Relating to CI label Apr 3, 2025
@chtruong814 chtruong814 added Run CICD and removed CI Relating to CI labels Apr 3, 2025
@chtruong814 chtruong814 changed the title temp: debug step summary ci: Fix unit test summary Apr 3, 2025
@github-actions github-actions Bot added Run CICD CI Relating to CI labels Apr 3, 2025
@chtruong814 chtruong814 force-pushed the chtruong/unit-test-summary branch from 1798766 to b6da023 Compare April 3, 2025 06:19
@chtruong814 chtruong814 marked this pull request as ready for review April 3, 2025 11:31
@chtruong814 chtruong814 requested a review from terrykong April 3, 2025 11:32
Comment thread docker/Dockerfile
…mmary

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@terrykong terrykong enabled auto-merge (squash) April 3, 2025 21:17
terrykong
terrykong previously approved these changes Apr 3, 2025
@terrykong terrykong disabled auto-merge April 3, 2025 22:25
@terrykong terrykong added this pull request to the merge queue Apr 3, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Apr 4, 2025
@chtruong814 chtruong814 added this pull request to the merge queue Apr 4, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 removed this pull request from the merge queue due to a manual request Apr 4, 2025
This reverts commit 0724806.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 enabled auto-merge (squash) April 4, 2025 17:23
@chtruong814 chtruong814 merged commit 15bb758 into main Apr 4, 2025
11 checks passed
@chtruong814 chtruong814 deleted the chtruong/unit-test-summary branch April 4, 2025 17:44
parthchadha pushed a commit that referenced this pull request Apr 11, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
KiddoZhu pushed a commit that referenced this pull request May 6, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
odelalleau pushed a commit to odelalleau/NeMo-RL that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants